git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: William Chargin <wchargin@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Duy Nguyen <pclouds@gmail.com>
Subject: Re: [PATCH v2] sha1-name.c: for ":/", find detached HEAD commits
Date: Thu, 12 Jul 2018 11:49:20 -0400	[thread overview]
Message-ID: <20180712154920.GA6380@sigill.intra.peff.net> (raw)
In-Reply-To: <20180712054909.29077-1-wchargin@gmail.com>

On Wed, Jul 11, 2018 at 10:49:09PM -0700, William Chargin wrote:

> This patch broadens the set of commits matched by ":/" pathspecs to
> include commits reachable from HEAD but not any named ref. This avoids
> surprising behavior when working with a detached HEAD and trying to
> refer to a commit that was recently created and only exists within the
> detached state.
> 
> If multiple worktrees exist, only the current worktree's HEAD is
> considered reachable. This is consistent with the existing behavior for
> other per-worktree refs: e.g., bisect refs are considered reachable, but
> only within the relevant worktree.
> 
> Signed-off-by: Jeff King <peff@peff.net>
> Signed-off-by: William Chargin <wchargin@gmail.com>
> Based-on-patch-by: Jeff King <peff@peff.net>
> ---
>  Documentation/revisions.txt   |  2 +-
>  sha1-name.c                   |  1 +
>  t/t4208-log-magic-pathspec.sh | 26 ++++++++++++++++++++++++++
>  3 files changed, 28 insertions(+), 1 deletion(-)

This one looks good to me. Thanks.

-Peff

  reply	other threads:[~2018-07-12 15:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-10 15:41 [PATCH] sha1-name.c: for ":/", find detached HEAD commits William Chargin
2018-07-10 17:54 ` Jeff King
2018-07-10 19:06 ` Junio C Hamano
2018-07-11  6:18   ` William Chargin
2018-07-11 12:32     ` Jeff King
2018-07-11 16:34       ` Junio C Hamano
2018-07-11 15:45 ` Duy Nguyen
2018-07-11 16:40   ` Jeff King
2018-07-11 17:20   ` Junio C Hamano
2018-07-11 17:37     ` Duy Nguyen
2018-07-11 17:49       ` William Chargin
2018-07-12  5:49         ` [PATCH v2] " William Chargin
2018-07-12 15:49           ` Jeff King [this message]
2018-07-12 16:04           ` Junio C Hamano
2018-07-12 16:14             ` William Chargin
2018-07-12 19:09               ` Junio C Hamano
2018-07-12 20:01                 ` William Chargin
2018-07-13 19:24                   ` Jeff King
2018-07-13 19:40                     ` William Chargin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180712154920.GA6380@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    --cc=wchargin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).