From: Viet Hung Tran <viethtran1620@gmail.com>
To: Git List <git@vger.kernel.org>
Subject: [GSoC][PATCH] git-ci: use pylint to analyze the git-p4 code
Date: Mon, 12 Mar 2018 23:36:43 -0400 [thread overview]
Message-ID: <20180313033643.7686-1-viethtran1620@gmail.com> (raw)
In-Reply-To: <CC42B5EC-6594-45CB-9821-E1C0ECED354E@gmail.com>
Hello Mr. Schneider,
Here is my link for the passed CI build I tested on my fork:
https://travis-ci.org/VietHTran/git/builds/352103333
In order to test .travis.yml configuration alone, I used a sample python
script call "test.py" that is already successfully tested on my computer
instead of using the git-p4.py like in the patch I submitted since the
git-p4.py file still reports a lot of errors when running pylint.
It is possible to fix all the git-p4.py errors. However, I think it would
be best to fix each error separately with multiple commits (each should
fix a specific problem such as indentication, variable naming, etc.)
since there are a lot of changes needed to be made in the codes. Since the
microproject requires that I submit one patch, I decided to submit a patch
that includes changes in .travis.yml only. If you like, I can also submit the
patches addressing changes on the git-p4.py that fix the pylint errors.
Thank you for feedback,
Viet
Signed-off-by: Viet Hung Tran <viethtran1620@gmail.com>
---
.travis.yml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/.travis.yml b/.travis.yml
index 5f5ee4f3b..581d75319 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -46,6 +46,16 @@ matrix:
- docker
before_install:
script: ci/run-linux32-docker.sh
+ - env: jobname=Pylint
+ compiler:
+ addons:
+ apt:
+ packages:
+ - python
+ before_install:
+ install: pip install --user pylint
+ script: pylint git-p4.py
+ after_failure:
- env: jobname=StaticAnalysis
os: linux
compiler:
--
2.16.2.440.gc6284da
next prev parent reply other threads:[~2018-03-13 3:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 2:08 [PATCH] git-ci: use pylint to analyze the git-p4 code Viet Hung Tran
2018-03-12 2:20 ` [GSoC][PATCH] " Viet Hung Tran
2018-03-12 10:15 ` Lars Schneider
2018-03-13 3:36 ` Viet Hung Tran [this message]
2018-03-13 14:45 ` Luke Diamand
2018-03-14 0:44 ` Viet Hung Tran
2018-03-14 3:28 ` [GSoC][PATCH 1/2] git-ci: add .pylintrc file Viet Hung Tran
2018-03-14 3:28 ` [GSoC][PATCH 2/2] git-ci: update .pylintrc to ignore current warning Viet Hung Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313033643.7686-1-viethtran1620@gmail.com \
--to=viethtran1620@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).