git@vger.kernel.org mailing list mirror (one of many)
 help / Atom feed
From: Luke Diamand <luke@diamand.org>
To: Viet Hung Tran <viethtran1620@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [GSoC][PATCH] git-ci: use pylint to analyze the git-p4 code
Date: Tue, 13 Mar 2018 14:45:27 +0000
Message-ID: <CAE5ih78HdDvN+x94H3Tzygis8QGROUe4B-yBubFH4simN2u9vQ@mail.gmail.com> (raw)
In-Reply-To: <20180313033643.7686-1-viethtran1620@gmail.com>

On 13 March 2018 at 03:36, Viet Hung Tran <viethtran1620@gmail.com> wrote:
> Hello Mr. Schneider,
>
> Here is my link for the passed CI build I tested on my fork:
> https://travis-ci.org/VietHTran/git/builds/352103333
>
> In order to test .travis.yml configuration alone, I used a sample python
> script call "test.py" that is already successfully tested on my computer
> instead of using the git-p4.py like in the patch I submitted since the
> git-p4.py file still reports a lot of errors when running pylint.
>
> It is possible to fix all the git-p4.py errors. However, I think it would
> be best to fix each error separately with multiple commits (each should
> fix a specific problem such as indentication, variable naming, etc.)
> since there are a lot of changes needed to be made in the codes. Since the
> microproject requires that I submit one patch, I decided to submit a patch
> that includes changes in .travis.yml only. If you like, I can also submit the
> patches addressing changes on the git-p4.py that fix the pylint errors.

You can turn down the amount of messages it spews out, at which point
it actually becomes quite useful.

I had a quick go with the list of enabled checkers found here:

   https://github.com/ClusterHQ/flocker/blob/master/.pylintrc

and it then gives about 40 warnings, all of which look like they could
do with fixing.

I think fixing them in a few patches would be OK, rather than
submitting 40 separate patches.

Quite a lot of the warnings are about the use of "file" - I've got a
change I'm working on which fixes some of those already.

Luke


>
> Thank you for feedback,
>
> Viet
>
> Signed-off-by: Viet Hung Tran <viethtran1620@gmail.com>
> ---
>  .travis.yml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/.travis.yml b/.travis.yml
> index 5f5ee4f3b..581d75319 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -46,6 +46,16 @@ matrix:
>          - docker
>        before_install:
>        script: ci/run-linux32-docker.sh
> +    - env: jobname=Pylint
> +      compiler:
> +      addons:
> +        apt:
> +          packages:
> +          - python
> +      before_install:
> +      install: pip install --user pylint
> +      script: pylint git-p4.py
> +      after_failure:
>      - env: jobname=StaticAnalysis
>        os: linux
>        compiler:
> --
> 2.16.2.440.gc6284da
>

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12  2:08 [PATCH] " Viet Hung Tran
2018-03-12  2:20 ` [GSoC][PATCH] " Viet Hung Tran
2018-03-12 10:15   ` Lars Schneider
2018-03-13  3:36     ` Viet Hung Tran
2018-03-13 14:45       ` Luke Diamand [this message]
2018-03-14  0:44         ` Viet Hung Tran
2018-03-14  3:28         ` [GSoC][PATCH 1/2] git-ci: add .pylintrc file Viet Hung Tran
2018-03-14  3:28           ` [GSoC][PATCH 2/2] git-ci: update .pylintrc to ignore current warning Viet Hung Tran

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAE5ih78HdDvN+x94H3Tzygis8QGROUe4B-yBubFH4simN2u9vQ@mail.gmail.com \
    --to=luke@diamand.org \
    --cc=git@vger.kernel.org \
    --cc=viethtran1620@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox