From: Lars Schneider <larsxschneider@gmail.com>
To: Viet Hung Tran <viethtran1620@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [GSoC][PATCH] git-ci: use pylint to analyze the git-p4 code
Date: Mon, 12 Mar 2018 11:15:05 +0100 [thread overview]
Message-ID: <CC42B5EC-6594-45CB-9821-E1C0ECED354E@gmail.com> (raw)
In-Reply-To: <20180312022003.8844-1-viethtran1620@gmail.com>
Hi Viet,
> On 12 Mar 2018, at 03:20, Viet Hung Tran <viethtran1620@gmail.com> wrote:
>
> This is my submission as a microproject for the Google Summer of code.
> I apologize for not setting the [GSoC] in my previous email
> at <20180312020855.7950-1-viethtran1620@gmail.com>.
> Please ignore it.
No worries :-)
> Add a new job named Pylint to .travis.yml in order to analyze git-p4 Python code.
> Although Travis CI have yet to implement continuous integration for multiple
> languages. Python package can be installed using apt packages. From there, pylint can be
> installed using pip and used to analyze git-p4.py file.
That looks interesting!
I assume you did run this on TravisCI already? Can you share a link?
I assume you did find errors? Can we fix them or are there too many?
If there are existing errors, how do we define a "successful" build?
Thanks for working on this,
Lars
>
> Signed-off-by: Viet Hung Tran <viethtran1620@gmail.com>
> ---
> .travis.yml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/.travis.yml b/.travis.yml
> index 5f5ee4f3b..581d75319 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -46,6 +46,16 @@ matrix:
> - docker
> before_install:
> script: ci/run-linux32-docker.sh
> + - env: jobname=Pylint
> + compiler:
> + addons:
> + apt:
> + packages:
> + - python
> + before_install:
> + install: pip install --user pylint
> + script: pylint git-p4.py
> + after_failure:
> - env: jobname=StaticAnalysis
> os: linux
> compiler:
> --
> 2.16.2.440.gc6284da
>
next prev parent reply other threads:[~2018-03-12 10:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 2:08 [PATCH] git-ci: use pylint to analyze the git-p4 code Viet Hung Tran
2018-03-12 2:20 ` [GSoC][PATCH] " Viet Hung Tran
2018-03-12 10:15 ` Lars Schneider [this message]
2018-03-13 3:36 ` Viet Hung Tran
2018-03-13 14:45 ` Luke Diamand
2018-03-14 0:44 ` Viet Hung Tran
2018-03-14 3:28 ` [GSoC][PATCH 1/2] git-ci: add .pylintrc file Viet Hung Tran
2018-03-14 3:28 ` [GSoC][PATCH 2/2] git-ci: update .pylintrc to ignore current warning Viet Hung Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC42B5EC-6594-45CB-9821-E1C0ECED354E@gmail.com \
--to=larsxschneider@gmail.com \
--cc=git@vger.kernel.org \
--cc=viethtran1620@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).