From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Jeff King <peff@peff.net>, Jonathan Nieder <jrnieder@gmail.com>,
Doron Behar <doron.behar@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Git mailing list <git@vger.kernel.org>,
Nicolas Morey-Chaisemartin <NMoreyChaisemartin@suse.com>
Subject: [PATCH v3] imap-send: URI encode server folder
Date: Tue, 19 Dec 2017 00:41:13 +0530 [thread overview]
Message-ID: <20171218191113.18600-1-kaartic.sivaraam@gmail.com> (raw)
In-Reply-To: <CAPig+cSOn8PV52aL0Ky5uUwFfNMWye93UQGioRiXjj0ze9HX+g@mail.gmail.com>
From: Nicolas Morey-Chaisemartin <NMoreyChaisemartin@suse.com>
When trying to send a patch using 'imap-send' with 'curl' and the
following configuration:
[imap]
folder = "[Gmail]/Drafts"
host = imaps://imap.gmail.com
port = 993
sslverify = false
results in the following error,
curl_easy_perform() failed: URL using bad/illegal format or missing URL
This is a consequence of not URI-encoding the folder portion of
the URL which contains characters such as '[' which are not
allowed in a URI. According to RFC3986, these characters should be
URI-encoded.
So, URI-encode the folder before adding it to the URI to ensure it doesn't
contain characters that aren't allowed in a URI.
Reported-by: Doron Behar <doron.behar@gmail.com>
Signed-off-by: Nicolas Morey-Chaisemartin <NMoreyChaisemartin@suse.com>
Signed-off-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
---
Changes in v3:
- updated commit message as suggested by Eric (convert past tense
to present tense) and added a few tweaks to it that striked me
Eric Sunshine <sunshine@sunshineco.com> writes:
> Thanks for taking up the slack.
You're welcome. It was easier than waiting for this patch to be
updated so it could get into 'pu' ;-)
imap-send.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/imap-send.c b/imap-send.c
index 54e6a80fd..36c7c1b4f 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1412,6 +1412,7 @@ static CURL *setup_curl(struct imap_server_conf *srvc, struct credential *cred)
{
CURL *curl;
struct strbuf path = STRBUF_INIT;
+ char *uri_encoded_folder;
if (curl_global_init(CURL_GLOBAL_ALL) != CURLE_OK)
die("curl_global_init failed");
@@ -1429,7 +1430,12 @@ static CURL *setup_curl(struct imap_server_conf *srvc, struct credential *cred)
strbuf_addstr(&path, server.host);
if (!path.len || path.buf[path.len - 1] != '/')
strbuf_addch(&path, '/');
- strbuf_addstr(&path, server.folder);
+
+ uri_encoded_folder = curl_easy_escape(curl, server.folder, 0);
+ if (!uri_encoded_folder)
+ die("failed to encode server folder");
+ strbuf_addstr(&path, uri_encoded_folder);
+ curl_free(uri_encoded_folder);
curl_easy_setopt(curl, CURLOPT_URL, path.buf);
strbuf_release(&path);
--
2.15.1.620.gb9897f467
next prev parent reply other threads:[~2017-12-18 19:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 17:13 imap-send with gmail: curl_easy_perform() failed: URL using bad/illegal format or missing URL Doron Behar
2017-11-30 2:04 ` Jonathan Nieder
2017-11-30 3:28 ` Jeff King
2017-11-30 3:55 ` Jeff King
2017-11-30 9:39 ` Nicolas Morey-Chaisemartin
2017-11-30 9:46 ` Daniel Stenberg
2017-11-30 9:51 ` Nicolas Morey-Chaisemartin
2017-11-30 9:55 ` Daniel Stenberg
2017-11-30 9:47 ` Nicolas Morey-Chaisemartin
2017-11-30 10:07 ` [PATCH] imap-send: URI encode server folder Nicolas Morey-Chaisemartin
2017-11-30 17:53 ` Eric Sunshine
2017-12-05 15:30 ` Junio C Hamano
2017-12-18 18:25 ` [PATCH v2] " Kaartic Sivaraam
2017-12-18 18:48 ` Eric Sunshine
2017-12-18 19:11 ` Kaartic Sivaraam [this message]
2017-12-18 22:19 ` [PATCH v3] " Jonathan Nieder
2017-12-18 22:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218191113.18600-1-kaartic.sivaraam@gmail.com \
--to=kaartic.sivaraam@gmail.com \
--cc=NMoreyChaisemartin@suse.com \
--cc=doron.behar@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).