git@vger.kernel.org mailing list mirror (one of many)
 help / Atom feed
From: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
To: git@vger.kernel.org
Cc: daniel@haxx.se, jrnieder@gmail.com, doron.behar@gmail.com, peff@peff.net
Subject: [PATCH] imap-send: URI encode server folder
Date: Thu, 30 Nov 2017 11:07:44 +0100
Message-ID: <18c9478b-19fc-69f2-229f-67c05a42d4f5@suse.com> (raw)
In-Reply-To: <20171129171301.l3coiflkfyy533yz@NUC.localdomain>

URI encode the server folder string before passing it to libcurl.
This fixes the access to the draft folder on Gmail accounts (named [Gmail]/Drafts)

Reported-by: Doron Behar <doron.behar@gmail.com>
Signed-off-by: Nicolas Morey-Chaisemartin <NMoreyChaisemartin@suse.com>
---
 imap-send.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/imap-send.c b/imap-send.c
index 54e6a80fd..36c7c1b4f 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1412,6 +1412,7 @@ static CURL *setup_curl(struct imap_server_conf *srvc, struct credential *cred)
 {
 	CURL *curl;
 	struct strbuf path = STRBUF_INIT;
+	char *uri_encoded_folder;
 
 	if (curl_global_init(CURL_GLOBAL_ALL) != CURLE_OK)
 		die("curl_global_init failed");
@@ -1429,7 +1430,12 @@ static CURL *setup_curl(struct imap_server_conf *srvc, struct credential *cred)
 	strbuf_addstr(&path, server.host);
 	if (!path.len || path.buf[path.len - 1] != '/')
 		strbuf_addch(&path, '/');
-	strbuf_addstr(&path, server.folder);
+
+	uri_encoded_folder = curl_easy_escape(curl, server.folder, 0);
+	if (!uri_encoded_folder)
+		die("failed to encode server folder");
+	strbuf_addstr(&path, uri_encoded_folder);
+	curl_free(uri_encoded_folder);
 
 	curl_easy_setopt(curl, CURLOPT_URL, path.buf);
 	strbuf_release(&path);
-- 
2.15.1.272.g8e603414b


  parent reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29 17:13 imap-send with gmail: curl_easy_perform() failed: URL using bad/illegal format or missing URL Doron Behar
2017-11-30  2:04 ` Jonathan Nieder
2017-11-30  3:28   ` Jeff King
2017-11-30  3:55     ` Jeff King
2017-11-30  9:39   ` Nicolas Morey-Chaisemartin
2017-11-30  9:46     ` Daniel Stenberg
2017-11-30  9:51       ` Nicolas Morey-Chaisemartin
2017-11-30  9:55         ` Daniel Stenberg
2017-11-30  9:47     ` Nicolas Morey-Chaisemartin
2017-11-30 10:07 ` Nicolas Morey-Chaisemartin [this message]
2017-11-30 17:53   ` [PATCH] imap-send: URI encode server folder Eric Sunshine
2017-12-05 15:30     ` Junio C Hamano
2017-12-18 18:25     ` [PATCH v2] " Kaartic Sivaraam
2017-12-18 18:48       ` Eric Sunshine
2017-12-18 19:11         ` [PATCH v3] " Kaartic Sivaraam
2017-12-18 22:19           ` Jonathan Nieder
2017-12-18 22:32           ` Junio C Hamano

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18c9478b-19fc-69f2-229f-67c05a42d4f5@suse.com \
    --to=nmoreychaisemartin@suse.com \
    --cc=daniel@haxx.se \
    --cc=doron.behar@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox