From: Eric Sunshine <sunshine@sunshineco.com>
To: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Cc: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>,
Jeff King <peff@peff.net>, Jonathan Nieder <jrnieder@gmail.com>,
Git List <git@vger.kernel.org>,
Doron Behar <doron.behar@gmail.com>
Subject: Re: [PATCH v2] imap-send: URI encode server folder
Date: Mon, 18 Dec 2017 13:48:35 -0500 [thread overview]
Message-ID: <CAPig+cSOn8PV52aL0Ky5uUwFfNMWye93UQGioRiXjj0ze9HX+g@mail.gmail.com> (raw)
In-Reply-To: <20171218182546.9962-1-kaartic.sivaraam@gmail.com>
On Mon, Dec 18, 2017 at 1:25 PM, Kaartic Sivaraam
<kaartic.sivaraam@gmail.com> wrote:
> From: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
> [...]
> resulted in the following error,
s/resulted/results/
> curl_easy_perform() failed: URL using bad/illegal format or missing URL
>
> That was a consequence of the not URI encoding the folder portion of
s/That was/This is/
s/the not/not/
s/URI encoding/URI-encoding/
> the URL which contained characters such as '[' which are not
s/contained/contains/
> allowed in a URI. According to RFC3986, these characters should be
> "URI encoded".
>
> So, URI encode the folder portion of the URL to ensure it doesn't
> contain characters that aren't allowed in a URI.
>
> Reported-by: Doron Behar <doron.behar@gmail.com>
> Signed-off-by: Nicolas Morey-Chaisemartin <NMoreyChaisemartin@suse.com>
> ---
>
> I came across the same issue that lead to this patch recently and found
> that this patch didn't make it in. So, I thought I could help out and
> hence this v2.
Thanks for taking up the slack.
next prev parent reply other threads:[~2017-12-18 18:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 17:13 imap-send with gmail: curl_easy_perform() failed: URL using bad/illegal format or missing URL Doron Behar
2017-11-30 2:04 ` Jonathan Nieder
2017-11-30 3:28 ` Jeff King
2017-11-30 3:55 ` Jeff King
2017-11-30 9:39 ` Nicolas Morey-Chaisemartin
2017-11-30 9:46 ` Daniel Stenberg
2017-11-30 9:51 ` Nicolas Morey-Chaisemartin
2017-11-30 9:55 ` Daniel Stenberg
2017-11-30 9:47 ` Nicolas Morey-Chaisemartin
2017-11-30 10:07 ` [PATCH] imap-send: URI encode server folder Nicolas Morey-Chaisemartin
2017-11-30 17:53 ` Eric Sunshine
2017-12-05 15:30 ` Junio C Hamano
2017-12-18 18:25 ` [PATCH v2] " Kaartic Sivaraam
2017-12-18 18:48 ` Eric Sunshine [this message]
2017-12-18 19:11 ` [PATCH v3] " Kaartic Sivaraam
2017-12-18 22:19 ` Jonathan Nieder
2017-12-18 22:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cSOn8PV52aL0Ky5uUwFfNMWye93UQGioRiXjj0ze9HX+g@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=doron.behar@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=kaartic.sivaraam@gmail.com \
--cc=nmoreychaisemartin@suse.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).