* [PATCH 1/1] completion: Add forgotten describe options
@ 2017-10-05 21:23 Thomas Braun
2017-10-05 22:17 ` Stefan Beller
2017-10-06 18:02 ` [PATCH v2 1/1] completion: add --broken and --dirty to describe Thomas Braun
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Braun @ 2017-10-05 21:23 UTC (permalink / raw)
To: git
Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de>
---
contrib/completion/git-completion.bash | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index d934417475..0e16f017a4 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1385,7 +1385,7 @@ _git_describe ()
__gitcomp "
--all --tags --contains --abbrev= --candidates=
--exact-match --debug --long --match --always --first-parent
- --exclude
+ --exclude --dirty --broken
"
return
esac
--
2.14.2.746.g8fb8a945bc.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] completion: Add forgotten describe options
2017-10-05 21:23 [PATCH 1/1] completion: Add forgotten describe options Thomas Braun
@ 2017-10-05 22:17 ` Stefan Beller
2017-10-06 17:53 ` Thomas Braun
2017-10-06 18:02 ` [PATCH v2 1/1] completion: add --broken and --dirty to describe Thomas Braun
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Beller @ 2017-10-05 22:17 UTC (permalink / raw)
To: Thomas Braun; +Cc: git@vger.kernel.org
On Thu, Oct 5, 2017 at 2:23 PM, Thomas Braun
<thomas.braun@virtuell-zuhause.de> wrote:
> completion: Add forgotten describe options
When/Why was it forgotten? git-blame thinks it was me in b0176ce6b5
(builtin/describe: introduce --broken flag, 2017-03-21)
Which do you add? (dirty and broken)
I had these questions when reading the subject (which is the
equivalent of reading the output of `git log --oneline` in the future)
I think a better wording might be
completion: add --broken and --dirty to describe
When the flags for broken and dirty were implemented in
b0176ce6b5 (builtin/describe: introduce --broken flag, 2017-03-21)
and 9f67d2e827 (Teach "git describe" --dirty option, 2009-10-21)
the completion was not updated, although these flags are useful
completions. Add them.
> Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de>
> ---
The patch looks correct.
Thanks,
Stefan
> contrib/completion/git-completion.bash | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index d934417475..0e16f017a4 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1385,7 +1385,7 @@ _git_describe ()
> __gitcomp "
> --all --tags --contains --abbrev= --candidates=
> --exact-match --debug --long --match --always --first-parent
> - --exclude
> + --exclude --dirty --broken
> "
> return
> esac
> --
> 2.14.2.746.g8fb8a945bc.dirty
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] completion: Add forgotten describe options
2017-10-05 22:17 ` Stefan Beller
@ 2017-10-06 17:53 ` Thomas Braun
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Braun @ 2017-10-06 17:53 UTC (permalink / raw)
To: Stefan Beller; +Cc: git
> Stefan Beller <sbeller@google.com> hat am 6. Oktober 2017 um 00:17 geschrieben:
> On Thu, Oct 5, 2017 at 2:23 PM, Thomas Braun
> <thomas.braun@virtuell-zuhause.de> wrote:
Hi Stefan,
> > completion: Add forgotten describe options
>
> When/Why was it forgotten? git-blame thinks it was me in b0176ce6b5
> (builtin/describe: introduce --broken flag, 2017-03-21)
> Which do you add? (dirty and broken)
>
> I had these questions when reading the subject (which is the
> equivalent of reading the output of `git log --oneline` in the future)
> I think a better wording might be
>
> completion: add --broken and --dirty to describe
>
> When the flags for broken and dirty were implemented in
> b0176ce6b5 (builtin/describe: introduce --broken flag, 2017-03-21)
> and 9f67d2e827 (Teach "git describe" --dirty option, 2009-10-21)
> the completion was not updated, although these flags are useful
> completions. Add them.
Thanks for the review. Your commit message is (obviously) much better than mine. Reroll follows.
> > ---
>
> The patch looks correct.
>
Thanks,
Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/1] completion: add --broken and --dirty to describe
2017-10-05 21:23 [PATCH 1/1] completion: Add forgotten describe options Thomas Braun
2017-10-05 22:17 ` Stefan Beller
@ 2017-10-06 18:02 ` Thomas Braun
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Braun @ 2017-10-06 18:02 UTC (permalink / raw)
To: git; +Cc: sbeller, gitster, Thomas Braun
When the flags for broken and dirty were implemented in
b0176ce6b5 (builtin/describe: introduce --broken flag, 2017-03-21)
and 9f67d2e827 (Teach "git describe" --dirty option, 2009-10-21)
the completion was not updated, although these flags are useful
completions. Add them.
Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de>
Helped-by: Stefan Beller <sbeller@google.com>
---
contrib/completion/git-completion.bash | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index d934417475..0e16f017a4 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1385,7 +1385,7 @@ _git_describe ()
__gitcomp "
--all --tags --contains --abbrev= --candidates=
--exact-match --debug --long --match --always --first-parent
- --exclude
+ --exclude --dirty --broken
"
return
esac
--
2.14.2.746.g8fb8a945bc.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-06 18:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-05 21:23 [PATCH 1/1] completion: Add forgotten describe options Thomas Braun
2017-10-05 22:17 ` Stefan Beller
2017-10-06 17:53 ` Thomas Braun
2017-10-06 18:02 ` [PATCH v2 1/1] completion: add --broken and --dirty to describe Thomas Braun
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).