From: Stefan Beller <sbeller@google.com>
To: Thomas Braun <thomas.braun@virtuell-zuhause.de>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 1/1] completion: Add forgotten describe options
Date: Thu, 5 Oct 2017 15:17:07 -0700 [thread overview]
Message-ID: <CAGZ79kbp=ewvdR8gXptwDjDdtM3TdC8qp1qR8XhETa7_CKgqRQ@mail.gmail.com> (raw)
In-Reply-To: <20171005212344.22887-1-thomas.braun@virtuell-zuhause.de>
On Thu, Oct 5, 2017 at 2:23 PM, Thomas Braun
<thomas.braun@virtuell-zuhause.de> wrote:
> completion: Add forgotten describe options
When/Why was it forgotten? git-blame thinks it was me in b0176ce6b5
(builtin/describe: introduce --broken flag, 2017-03-21)
Which do you add? (dirty and broken)
I had these questions when reading the subject (which is the
equivalent of reading the output of `git log --oneline` in the future)
I think a better wording might be
completion: add --broken and --dirty to describe
When the flags for broken and dirty were implemented in
b0176ce6b5 (builtin/describe: introduce --broken flag, 2017-03-21)
and 9f67d2e827 (Teach "git describe" --dirty option, 2009-10-21)
the completion was not updated, although these flags are useful
completions. Add them.
> Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de>
> ---
The patch looks correct.
Thanks,
Stefan
> contrib/completion/git-completion.bash | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index d934417475..0e16f017a4 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1385,7 +1385,7 @@ _git_describe ()
> __gitcomp "
> --all --tags --contains --abbrev= --candidates=
> --exact-match --debug --long --match --always --first-parent
> - --exclude
> + --exclude --dirty --broken
> "
> return
> esac
> --
> 2.14.2.746.g8fb8a945bc.dirty
>
next prev parent reply other threads:[~2017-10-05 22:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 21:23 [PATCH 1/1] completion: Add forgotten describe options Thomas Braun
2017-10-05 22:17 ` Stefan Beller [this message]
2017-10-06 17:53 ` Thomas Braun
2017-10-06 18:02 ` [PATCH v2 1/1] completion: add --broken and --dirty to describe Thomas Braun
-- strict thread matches above, loose matches on Subject: below --
2017-10-05 21:45 [PATCH 1/1] completion: Add forgotten describe options Thomas Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kbp=ewvdR8gXptwDjDdtM3TdC8qp1qR8XhETa7_CKgqRQ@mail.gmail.com' \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=thomas.braun@virtuell-zuhause.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).