git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [bug] git version 2.4.12 color.ui = always breaks git add -p
@ 2017-10-03 21:33 Christian Rebischke
  2017-10-03 21:47 ` Jonathan Nieder
  0 siblings, 1 reply; 3+ messages in thread
From: Christian Rebischke @ 2017-10-03 21:33 UTC (permalink / raw)
  To: git

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

Hello everybody,
I played around with my gitconfig and I think I found a bug while doing
so. I set the following lines in my gitconfig:

[color]
    ui = always

When I try to use `git add -p <filename>` I don't see the 'Stage
this hunk'-dialog anymore. First I thought it's some other configuration
but now I can definitly say that this configuration breaks `git add -p`
interactive mode.

best regards

chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [bug] git version 2.4.12 color.ui = always breaks git add -p
  2017-10-03 21:33 [bug] git version 2.4.12 color.ui = always breaks git add -p Christian Rebischke
@ 2017-10-03 21:47 ` Jonathan Nieder
  2017-10-03 23:53   ` Jeff King
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Nieder @ 2017-10-03 21:47 UTC (permalink / raw)
  To: Christian Rebischke; +Cc: git, Jeff King

Hi Christian,

Christian Rebischke wrote:

> I played around with my gitconfig and I think I found a bug while doing
> so. I set the following lines in my gitconfig:
>
> [color]
>     ui = always
>
> When I try to use `git add -p <filename>` I don't see the 'Stage
> this hunk'-dialog anymore. First I thought it's some other configuration
> but now I can definitly say that this configuration breaks `git add -p`
> interactive mode.

Do the patches at
https://public-inbox.org/git/20171003133713.ccxv6clrmuuhhc3u@sigill.intra.peff.net/
help?

Thanks and hope that helps,
Jonathan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [bug] git version 2.4.12 color.ui = always breaks git add -p
  2017-10-03 21:47 ` Jonathan Nieder
@ 2017-10-03 23:53   ` Jeff King
  0 siblings, 0 replies; 3+ messages in thread
From: Jeff King @ 2017-10-03 23:53 UTC (permalink / raw)
  To: Christian Rebischke; +Cc: Jonathan Nieder, git

On Tue, Oct 03, 2017 at 02:47:48PM -0700, Jonathan Nieder wrote:

> Hi Christian,
> 
> Christian Rebischke wrote:
> 
> > I played around with my gitconfig and I think I found a bug while doing
> > so. I set the following lines in my gitconfig:
> >
> > [color]
> >     ui = always
> >
> > When I try to use `git add -p <filename>` I don't see the 'Stage
> > this hunk'-dialog anymore. First I thought it's some other configuration
> > but now I can definitly say that this configuration breaks `git add -p`
> > interactive mode.
> 
> Do the patches at
> https://public-inbox.org/git/20171003133713.ccxv6clrmuuhhc3u@sigill.intra.peff.net/
> help?

If it makes it any easier to test, they are also available as a fetch
from:

  https://github.com/peff/git jk/color-no-always

-Peff

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-10-03 23:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-03 21:33 [bug] git version 2.4.12 color.ui = always breaks git add -p Christian Rebischke
2017-10-03 21:47 ` Jonathan Nieder
2017-10-03 23:53   ` Jeff King

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).