git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Christian Rebischke <Chris.Rebischke@archlinux.org>
Cc: Jonathan Nieder <jrnieder@gmail.com>, git@vger.kernel.org
Subject: Re: [bug] git version 2.4.12 color.ui = always breaks git add -p
Date: Tue, 3 Oct 2017 19:53:09 -0400	[thread overview]
Message-ID: <20171003235309.tysfbxqmb7zbiaic@sigill.intra.peff.net> (raw)
In-Reply-To: <20171003214748.GA19555@aiede.mtv.corp.google.com>

On Tue, Oct 03, 2017 at 02:47:48PM -0700, Jonathan Nieder wrote:

> Hi Christian,
> 
> Christian Rebischke wrote:
> 
> > I played around with my gitconfig and I think I found a bug while doing
> > so. I set the following lines in my gitconfig:
> >
> > [color]
> >     ui = always
> >
> > When I try to use `git add -p <filename>` I don't see the 'Stage
> > this hunk'-dialog anymore. First I thought it's some other configuration
> > but now I can definitly say that this configuration breaks `git add -p`
> > interactive mode.
> 
> Do the patches at
> https://public-inbox.org/git/20171003133713.ccxv6clrmuuhhc3u@sigill.intra.peff.net/
> help?

If it makes it any easier to test, they are also available as a fetch
from:

  https://github.com/peff/git jk/color-no-always

-Peff

      reply	other threads:[~2017-10-03 23:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-03 21:33 [bug] git version 2.4.12 color.ui = always breaks git add -p Christian Rebischke
2017-10-03 21:47 ` Jonathan Nieder
2017-10-03 23:53   ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171003235309.tysfbxqmb7zbiaic@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=Chris.Rebischke@archlinux.org \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).