* [PATCH] Add t/helper/test-write-cache to .gitignore
@ 2017-08-28 20:06 Jonathan Tan
2017-08-28 21:09 ` Brandon Williams
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Tan @ 2017-08-28 20:06 UTC (permalink / raw)
To: git; +Cc: Jonathan Tan, kewillf
This new binary was introduced in commit 3921a0b ("perf: add test for
writing the index", 2017-08-21), but a .gitignore entry was not added
for it. Add that entry.
Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
---
t/helper/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/t/helper/.gitignore b/t/helper/.gitignore
index 721650256..7c9d28a83 100644
--- a/t/helper/.gitignore
+++ b/t/helper/.gitignore
@@ -35,3 +35,4 @@
/test-svn-fe
/test-urlmatch-normalization
/test-wildmatch
+/test-write-cache
--
2.14.1.581.gf28d330327-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Add t/helper/test-write-cache to .gitignore
2017-08-28 20:06 [PATCH] Add t/helper/test-write-cache to .gitignore Jonathan Tan
@ 2017-08-28 21:09 ` Brandon Williams
2017-09-20 18:47 ` Jonathan Nieder
0 siblings, 1 reply; 3+ messages in thread
From: Brandon Williams @ 2017-08-28 21:09 UTC (permalink / raw)
To: Jonathan Tan; +Cc: git, kewillf
On 08/28, Jonathan Tan wrote:
> This new binary was introduced in commit 3921a0b ("perf: add test for
> writing the index", 2017-08-21), but a .gitignore entry was not added
> for it. Add that entry.
>
> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Looks good to me
> ---
> t/helper/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/t/helper/.gitignore b/t/helper/.gitignore
> index 721650256..7c9d28a83 100644
> --- a/t/helper/.gitignore
> +++ b/t/helper/.gitignore
> @@ -35,3 +35,4 @@
> /test-svn-fe
> /test-urlmatch-normalization
> /test-wildmatch
> +/test-write-cache
> --
> 2.14.1.581.gf28d330327-goog
>
--
Brandon Williams
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Add t/helper/test-write-cache to .gitignore
2017-08-28 21:09 ` Brandon Williams
@ 2017-09-20 18:47 ` Jonathan Nieder
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Nieder @ 2017-09-20 18:47 UTC (permalink / raw)
To: Brandon Williams; +Cc: Jonathan Tan, git, kewillf, Junio C Hamano
Brandon Williams wrote:
> On 08/28, Jonathan Tan wrote:
>> This new binary was introduced in commit 3921a0b ("perf: add test for
>> writing the index", 2017-08-21), but a .gitignore entry was not added
>> for it. Add that entry.
>>
>> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
>
> Looks good to me
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
as well.
I wonder if we can automate this a little. Some thoughts:
A. We could include a test that all the binaries named in
TEST_PROGRAMS_NEED_X are also named in t/helper/.gitignore. That
way tests would fail if this ever falls out of date again.
B. Even better would be if we could have /t/helper/test-* in
.gitignore. E.g. if we rename test-*.c to *.c (e.g.
t/helper/ctype.c instead of t/helper/test-ctype.c), then the test
helper source file names would be easier to type and maintaining
this .gitignore would become a problem of the past.
What do you think?
Jonathan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-20 18:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-28 20:06 [PATCH] Add t/helper/test-write-cache to .gitignore Jonathan Tan
2017-08-28 21:09 ` Brandon Williams
2017-09-20 18:47 ` Jonathan Nieder
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).