From: Jonathan Nieder <jrnieder@gmail.com>
To: Brandon Williams <bmwill@google.com>
Cc: Jonathan Tan <jonathantanmy@google.com>,
git@vger.kernel.org, kewillf@microsoft.com,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Add t/helper/test-write-cache to .gitignore
Date: Wed, 20 Sep 2017 11:47:53 -0700 [thread overview]
Message-ID: <20170920184753.GC27425@aiede.mtv.corp.google.com> (raw)
In-Reply-To: <20170828210939.GA71562@google.com>
Brandon Williams wrote:
> On 08/28, Jonathan Tan wrote:
>> This new binary was introduced in commit 3921a0b ("perf: add test for
>> writing the index", 2017-08-21), but a .gitignore entry was not added
>> for it. Add that entry.
>>
>> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
>
> Looks good to me
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
as well.
I wonder if we can automate this a little. Some thoughts:
A. We could include a test that all the binaries named in
TEST_PROGRAMS_NEED_X are also named in t/helper/.gitignore. That
way tests would fail if this ever falls out of date again.
B. Even better would be if we could have /t/helper/test-* in
.gitignore. E.g. if we rename test-*.c to *.c (e.g.
t/helper/ctype.c instead of t/helper/test-ctype.c), then the test
helper source file names would be easier to type and maintaining
this .gitignore would become a problem of the past.
What do you think?
Jonathan
prev parent reply other threads:[~2017-09-20 18:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 20:06 [PATCH] Add t/helper/test-write-cache to .gitignore Jonathan Tan
2017-08-28 21:09 ` Brandon Williams
2017-09-20 18:47 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920184753.GC27425@aiede.mtv.corp.google.com \
--to=jrnieder@gmail.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=kewillf@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).