* [PATCH] fsck: cleanup unused variable
@ 2017-07-26 1:34 Jonathan Tan
2017-07-26 13:17 ` Jeff King
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Tan @ 2017-07-26 1:34 UTC (permalink / raw)
To: git; +Cc: Jonathan Tan
Remove the unused variable "heads" from cmd_fsck().
This variable was made unused in commit c3271a0 ("fsck: do not fallback
"git fsck <bogus>" to "git fsck"", 2017-01-17).
Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
---
While working on fsck, I noticed one more possible cleanup.
---
builtin/fsck.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/builtin/fsck.c b/builtin/fsck.c
index 99dea7adf..cc5a5cfab 100644
--- a/builtin/fsck.c
+++ b/builtin/fsck.c
@@ -667,7 +667,7 @@ static struct option fsck_opts[] = {
int cmd_fsck(int argc, const char **argv, const char *prefix)
{
- int i, heads;
+ int i;
struct alternate_object_database *alt;
errors_found = 0;
@@ -735,7 +735,6 @@ int cmd_fsck(int argc, const char **argv, const char *prefix)
}
}
- heads = 0;
for (i = 0; i < argc; i++) {
const char *arg = argv[i];
unsigned char sha1[20];
@@ -753,7 +752,6 @@ int cmd_fsck(int argc, const char **argv, const char *prefix)
add_decoration(fsck_walk_options.object_names,
obj, xstrdup(arg));
mark_object_reachable(obj);
- heads++;
continue;
}
error("invalid parameter: expected sha1, got '%s'", arg);
--
2.14.0.rc0.400.g1c36432dff-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fsck: cleanup unused variable
2017-07-26 1:34 [PATCH] fsck: cleanup unused variable Jonathan Tan
@ 2017-07-26 13:17 ` Jeff King
0 siblings, 0 replies; 2+ messages in thread
From: Jeff King @ 2017-07-26 13:17 UTC (permalink / raw)
To: Jonathan Tan; +Cc: git
On Tue, Jul 25, 2017 at 06:34:56PM -0700, Jonathan Tan wrote:
> Remove the unused variable "heads" from cmd_fsck().
>
> This variable was made unused in commit c3271a0 ("fsck: do not fallback
> "git fsck <bogus>" to "git fsck"", 2017-01-17).
Thanks, I should have caught this then.
The patch is obviously correct, though I'm curious why gcc's
-Wunused-but-set-variable didn't catch this.
-Peff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-26 13:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-26 1:34 [PATCH] fsck: cleanup unused variable Jonathan Tan
2017-07-26 13:17 ` Jeff King
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).