git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fsck: cleanup unused variable
Date: Wed, 26 Jul 2017 09:17:29 -0400	[thread overview]
Message-ID: <20170726131729.o6bp2qmlqpl674zt@sigill.intra.peff.net> (raw)
In-Reply-To: <20170726013456.4187-1-jonathantanmy@google.com>

On Tue, Jul 25, 2017 at 06:34:56PM -0700, Jonathan Tan wrote:

> Remove the unused variable "heads" from cmd_fsck().
> 
> This variable was made unused in commit c3271a0 ("fsck: do not fallback
> "git fsck <bogus>" to "git fsck"", 2017-01-17).

Thanks, I should have caught this then.

The patch is obviously correct, though I'm curious why gcc's
-Wunused-but-set-variable didn't catch this.

-Peff

      reply	other threads:[~2017-07-26 13:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-26  1:34 [PATCH] fsck: cleanup unused variable Jonathan Tan
2017-07-26 13:17 ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170726131729.o6bp2qmlqpl674zt@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=jonathantanmy@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).