From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@jeffhostetler.com, git@vger.kernel.org, gitster@pobox.com,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v2 1/2] read-cache: skip index SHA verification
Date: Mon, 27 Mar 2017 19:39:53 -0400 [thread overview]
Message-ID: <20170327233953.7si3eex2y46hxpap@sigill.intra.peff.net> (raw)
In-Reply-To: <20170327233210.GO31294@aiede.mtv.corp.google.com>
On Mon, Mar 27, 2017 at 04:32:10PM -0700, Jonathan Nieder wrote:
> Jeff King wrote:
>
> > Hrm, there shouldn't be any dependency of the config on the index (and
> > there are a handful of options which impact the index already). Did you
> > try it and run into problems?
> >
> > In general, I'd much rather see us either:
> >
> > 1. Rip the code out entirely if it is not meant to be configurable,
> > and cannot be triggered by the actual git binary.
> >
> > or
> >
> > 2. Make it configurable, even if most people wouldn't use it. And then
> > have a test to exercise it using a git command (unlike the one-off
> > test helper, which isn't run at all).
>
> Agreed with this, leaning toward (1).
>
> If "git fsck" verifies the .git/index file then I don't see any need
> for other commands to.
Yeah, code that _can_ be run but almost nobody does is possibly worse
than code that can't be run. :)
I agree that it would make sense for fsck to check it, though (just like
it checks the actual pack trailer checksums, even though normal
operations do not).
-Peff
next prev parent reply other threads:[~2017-03-27 23:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 21:09 [PATCH v2 0/2] read-cache: call verify_hdr() in a background thread git
2017-03-27 21:09 ` [PATCH v2 1/2] read-cache: skip index SHA verification git
2017-03-27 22:44 ` Jeff King
2017-03-27 23:32 ` Jonathan Nieder
2017-03-27 23:39 ` Jeff King [this message]
2017-03-28 15:27 ` Jeff Hostetler
2017-03-28 15:37 ` Jeff King
2017-03-27 21:09 ` [PATCH v2 2/2] skip_verify_index: helper test git
2017-03-27 22:45 ` [PATCH v2 0/2] read-cache: call verify_hdr() in a background thread Jeff King
2017-03-28 15:30 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327233953.7si3eex2y46hxpap@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).