From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 603071FCA0 for ; Mon, 27 Mar 2017 23:48:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752789AbdC0XrS (ORCPT ); Mon, 27 Mar 2017 19:47:18 -0400 Received: from cloud.peff.net ([104.130.231.41]:52669 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752575AbdC0XrR (ORCPT ); Mon, 27 Mar 2017 19:47:17 -0400 Received: (qmail 22863 invoked by uid 109); 27 Mar 2017 23:39:56 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Mon, 27 Mar 2017 23:39:56 +0000 Received: (qmail 3577 invoked by uid 111); 27 Mar 2017 23:40:11 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Mon, 27 Mar 2017 19:40:11 -0400 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Mon, 27 Mar 2017 19:39:53 -0400 Date: Mon, 27 Mar 2017 19:39:53 -0400 From: Jeff King To: Jonathan Nieder Cc: git@jeffhostetler.com, git@vger.kernel.org, gitster@pobox.com, Jeff Hostetler Subject: Re: [PATCH v2 1/2] read-cache: skip index SHA verification Message-ID: <20170327233953.7si3eex2y46hxpap@sigill.intra.peff.net> References: <1490648979-49580-1-git-send-email-git@jeffhostetler.com> <1490648979-49580-2-git-send-email-git@jeffhostetler.com> <20170327224408.2bzh5vfa6deni6fm@sigill.intra.peff.net> <20170327233210.GO31294@aiede.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170327233210.GO31294@aiede.mtv.corp.google.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Mar 27, 2017 at 04:32:10PM -0700, Jonathan Nieder wrote: > Jeff King wrote: > > > Hrm, there shouldn't be any dependency of the config on the index (and > > there are a handful of options which impact the index already). Did you > > try it and run into problems? > > > > In general, I'd much rather see us either: > > > > 1. Rip the code out entirely if it is not meant to be configurable, > > and cannot be triggered by the actual git binary. > > > > or > > > > 2. Make it configurable, even if most people wouldn't use it. And then > > have a test to exercise it using a git command (unlike the one-off > > test helper, which isn't run at all). > > Agreed with this, leaning toward (1). > > If "git fsck" verifies the .git/index file then I don't see any need > for other commands to. Yeah, code that _can_ be run but almost nobody does is possibly worse than code that can't be run. :) I agree that it would make sense for fsck to check it, though (just like it checks the actual pack trailer checksums, even though normal operations do not). -Peff