From: Jeff King <peff@peff.net>
To: git@jeffhostetler.com
Cc: git@vger.kernel.org, gitster@pobox.com,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v2 0/2] read-cache: call verify_hdr() in a background thread
Date: Mon, 27 Mar 2017 18:45:05 -0400 [thread overview]
Message-ID: <20170327224505.ngp2gel3yvqcjrhw@sigill.intra.peff.net> (raw)
In-Reply-To: <1490648979-49580-1-git-send-email-git@jeffhostetler.com>
On Mon, Mar 27, 2017 at 09:09:37PM +0000, git@jeffhostetler.com wrote:
> From: Jeff Hostetler <jeffhost@microsoft.com>
>
> Version 2 of this patch series simplifies this to just
> turn off the hash verification. Independent comments
> from Linus and Peff suggested that we could just turn
> this off and not worry about it. So I've updated this
> patch to do that. I added a global variable to allow
> the original code path to be used. I also added a
> t/helper command to demonstrate the differences.
>
> On the Linux repo, the effect is rather trivial:
>
> $ ~/work/gfw/t/helper/test-skip-verify-index -c 3
> 0.029884 0 [cache_nr 57994]
> 0.031035 0 [cache_nr 57994]
> 0.024308 0 [cache_nr 57994]
> 0.028409 0 avg
> 0.018359 1 [cache_nr 57994]
> 0.017025 1 [cache_nr 57994]
> 0.011087 1 [cache_nr 57994]
> 0.015490 1 avg
>
> On my Windows source tree (450MB index), I'm seeing a
> savings of 0.6 seconds -- read_index() went from 1.2 to 0.6
> seconds.
Very satisfying. I assume that was with OpenSSL as the SHA-1
implementation (sha1dc would have been much slower on 450MB, I think).
-Peff
next prev parent reply other threads:[~2017-03-27 22:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 21:09 [PATCH v2 0/2] read-cache: call verify_hdr() in a background thread git
2017-03-27 21:09 ` [PATCH v2 1/2] read-cache: skip index SHA verification git
2017-03-27 22:44 ` Jeff King
2017-03-27 23:32 ` Jonathan Nieder
2017-03-27 23:39 ` Jeff King
2017-03-28 15:27 ` Jeff Hostetler
2017-03-28 15:37 ` Jeff King
2017-03-27 21:09 ` [PATCH v2 2/2] skip_verify_index: helper test git
2017-03-27 22:45 ` Jeff King [this message]
2017-03-28 15:30 ` [PATCH v2 0/2] read-cache: call verify_hdr() in a background thread Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327224505.ngp2gel3yvqcjrhw@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).