From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Andreas Schwab <schwab@linux-m68k.org>,
git@vger.kernel.org
Subject: Re: [ANNOUNCE] Git v2.9.1
Date: Tue, 12 Jul 2016 03:39:12 -0400 [thread overview]
Message-ID: <20160712073912.GA26431@sigill.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1607120927410.6426@virtualbox>
On Tue, Jul 12, 2016 at 09:30:28AM +0200, Johannes Schindelin wrote:
> On Mon, 11 Jul 2016, Junio C Hamano wrote:
>
> > Those who care about 32-bit builds need to start building and
> > testing 'next' and 'master' regularly, or similar breakages are
> > bound to continue happening X-<.
>
> Please note that "unsigned long" is 32-bit even on 64-bit Windows.
Yeah, that was part of the reason my run-time test checked
sizeof(unsigned long), and not any kind of "are we 64-bit?" compiler
options or output. So the "64BIT" prereq is actually a bit of a
misnomer; it is really "is your ULL 64-bit, because that's what we use
for time". :-/
> FWIW I have this monster patch as a starting point (I plan to work more on
> this today):
Cool! Thanks for working on this.
I suspect we should still do something about skipping those tests,
though, if only because the v2.9.x maint track is broken, and switching
to time_t is a sufficiently large change that we probably don't want it
for maint (it _seems_ like it shouldn't cause any problems, but I'm
wondering if we might inadvertently trigger funny issues around
signedness or something).
> From b65de5a56e18b038d432ba828d7714880b8e285c Mon Sep 17 00:00:00 2001
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
> Date: Tue, 12 Jul 2016 09:09:07 +0200
> Subject: [PATCH] HOTFIX: use time_t wherever appropriate
>
> Git's source code assumes that unsigned long is at least as precise as
> time_t. Well, Git's source code is wrong.
Another problem with "unsigned long" is that we cannot handle times
older than 1970. Assuming most systems are sane enough to have a signed
time_t these days, this would fix that problem as well.
-Peff
next prev parent reply other threads:[~2016-07-12 7:39 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 20:13 [ANNOUNCE] Git v2.9.1 Junio C Hamano
2016-07-11 21:35 ` Andreas Schwab
2016-07-11 23:54 ` Jeff King
2016-07-12 0:40 ` Anders Kaseorg
2016-07-12 14:06 ` Jeff King
2016-07-12 0:56 ` Eric Wong
2016-07-12 1:15 ` Jeff King
2016-07-12 1:59 ` Junio C Hamano
2016-07-12 3:57 ` Jeff King
2016-07-12 15:55 ` Junio C Hamano
2016-07-12 7:30 ` Johannes Schindelin
2016-07-12 7:39 ` Jeff King [this message]
2016-07-12 11:25 ` Johannes Schindelin
2016-07-12 14:04 ` Jeff King
2016-07-13 11:35 ` Johannes Schindelin
2016-07-13 16:03 ` Junio C Hamano
2016-07-13 19:10 ` Johannes Schindelin
2016-07-13 19:41 ` Junio C Hamano
2016-07-14 7:50 ` Johannes Schindelin
2016-07-12 18:12 ` Junio C Hamano
2016-07-13 1:53 ` Junio C Hamano
2016-07-13 2:01 ` Jeff King
2016-07-13 16:05 ` Junio C Hamano
2016-07-13 18:52 ` Johannes Schindelin
2016-07-13 19:07 ` Junio C Hamano
2016-07-14 7:45 ` Johannes Schindelin
2016-07-14 8:01 ` Andreas Schwab
2016-07-14 8:15 ` Jeff King
2016-07-14 16:06 ` Johannes Schindelin
2016-07-12 7:40 ` Andreas Schwab
2016-07-12 10:57 ` Johannes Schindelin
2016-07-12 13:00 ` Andreas Schwab
2016-07-12 13:22 ` Johannes Schindelin
2016-07-12 13:31 ` Andreas Schwab
2016-07-12 13:46 ` Jeff King
2016-07-12 18:38 ` Duy Nguyen
2016-07-13 11:29 ` Johannes Schindelin
2016-07-13 11:25 ` Johannes Schindelin
2016-07-12 14:34 ` Junio C Hamano
2016-07-12 15:16 ` Jeff King
2016-07-12 15:25 ` Junio C Hamano
2016-07-12 15:35 ` Jeff King
2016-07-12 15:41 ` Junio C Hamano
2016-07-12 16:09 ` Jeff King
2016-07-12 16:25 ` Junio C Hamano
2016-07-13 14:00 ` Johannes Schindelin
2016-07-13 16:10 ` Junio C Hamano
2016-07-13 18:53 ` Johannes Schindelin
2016-07-12 18:15 ` Andreas Schwab
2016-07-13 20:43 ` Junio C Hamano
2016-07-14 7:38 ` Lars Schneider
2016-07-16 5:50 ` Duy Nguyen
2016-07-14 7:58 ` 32-bit Travis, was " Johannes Schindelin
2016-07-14 9:12 ` Mike Hommey
2016-07-14 10:58 ` Johannes Schindelin
2016-07-15 1:59 ` Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712073912.GA26431@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).