From: Jeff King <peff@peff.net>
To: Eric Wong <e@80x24.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [ANNOUNCE] Git v2.9.1
Date: Mon, 11 Jul 2016 21:15:33 -0400 [thread overview]
Message-ID: <20160712011533.GA28601@sigill.intra.peff.net> (raw)
In-Reply-To: <20160712005611.GA16810@dcvr.yhbt.net>
On Tue, Jul 12, 2016 at 12:56:11AM +0000, Eric Wong wrote:
> Jeff King <peff@peff.net> wrote:
> > Otherwise, we'll have to skip the test, perhaps with something like the
> > patch below. I suspect the problem is actually the size of "unsigned
> > long", not time_t, as we use that internally for a bunch of time
> > computation.
>
> We should probably be using int64_t for time calculations;
> "unsigned long" is 32-bits on 32-bit x86 systems.
I'd agree (or probably just "time_t", which I would hope would be a
future-proof length even on 32-bit systems).
It's just that it's baked into a lot of different function interfaces
and structs in the code, and nobody has taken the time to review and
change it all (since it doesn't actually affect current timestamps and
won't for a while).
-Peff
next prev parent reply other threads:[~2016-07-12 1:15 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 20:13 [ANNOUNCE] Git v2.9.1 Junio C Hamano
2016-07-11 21:35 ` Andreas Schwab
2016-07-11 23:54 ` Jeff King
2016-07-12 0:40 ` Anders Kaseorg
2016-07-12 14:06 ` Jeff King
2016-07-12 0:56 ` Eric Wong
2016-07-12 1:15 ` Jeff King [this message]
2016-07-12 1:59 ` Junio C Hamano
2016-07-12 3:57 ` Jeff King
2016-07-12 15:55 ` Junio C Hamano
2016-07-12 7:30 ` Johannes Schindelin
2016-07-12 7:39 ` Jeff King
2016-07-12 11:25 ` Johannes Schindelin
2016-07-12 14:04 ` Jeff King
2016-07-13 11:35 ` Johannes Schindelin
2016-07-13 16:03 ` Junio C Hamano
2016-07-13 19:10 ` Johannes Schindelin
2016-07-13 19:41 ` Junio C Hamano
2016-07-14 7:50 ` Johannes Schindelin
2016-07-12 18:12 ` Junio C Hamano
2016-07-13 1:53 ` Junio C Hamano
2016-07-13 2:01 ` Jeff King
2016-07-13 16:05 ` Junio C Hamano
2016-07-13 18:52 ` Johannes Schindelin
2016-07-13 19:07 ` Junio C Hamano
2016-07-14 7:45 ` Johannes Schindelin
2016-07-14 8:01 ` Andreas Schwab
2016-07-14 8:15 ` Jeff King
2016-07-14 16:06 ` Johannes Schindelin
2016-07-12 7:40 ` Andreas Schwab
2016-07-12 10:57 ` Johannes Schindelin
2016-07-12 13:00 ` Andreas Schwab
2016-07-12 13:22 ` Johannes Schindelin
2016-07-12 13:31 ` Andreas Schwab
2016-07-12 13:46 ` Jeff King
2016-07-12 18:38 ` Duy Nguyen
2016-07-13 11:29 ` Johannes Schindelin
2016-07-13 11:25 ` Johannes Schindelin
2016-07-12 14:34 ` Junio C Hamano
2016-07-12 15:16 ` Jeff King
2016-07-12 15:25 ` Junio C Hamano
2016-07-12 15:35 ` Jeff King
2016-07-12 15:41 ` Junio C Hamano
2016-07-12 16:09 ` Jeff King
2016-07-12 16:25 ` Junio C Hamano
2016-07-13 14:00 ` Johannes Schindelin
2016-07-13 16:10 ` Junio C Hamano
2016-07-13 18:53 ` Johannes Schindelin
2016-07-12 18:15 ` Andreas Schwab
2016-07-13 20:43 ` Junio C Hamano
2016-07-14 7:38 ` Lars Schneider
2016-07-16 5:50 ` Duy Nguyen
2016-07-14 7:58 ` 32-bit Travis, was " Johannes Schindelin
2016-07-14 9:12 ` Mike Hommey
2016-07-14 10:58 ` Johannes Schindelin
2016-07-15 1:59 ` Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712011533.GA28601@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).