list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Nieder <>
To: "Kyle J. McKay" <>
Cc: David Rothenberger <>,
Subject: Re: [PATCH v3 1/2] add new temp_is_locked function
Date: Thu, 18 Jul 2013 12:35:52 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Kyle J. McKay wrote:

> That change was made as a result of this feedback:
> On Jul 6, 2013, at 17:11, Jonathan Nieder wrote:
>> Kyle McKay wrote:
>>> The temp_is_locked function can be used to determine whether
>>> or not a given name previously passed to temp_acquire is
>>> currently locked.
>> [...]
>>> +=item temp_is_locked ( NAME )
>>> +
>>> +Returns true if the file mapped to C<NAME> is currently locked.
>>> +
>>> +If true is returned, an attempt to C<temp_acquire()> the same
> [snip]
>> Looking more closely, it looks like this is factoring out the idiom
>> for checking if a name is already in use from the _temp_cache
>> function.  Would it make sense for _temp_cache to call this helper?
> So I think the answer is it does not make sense for _temp_cache to
> call this helper.

Thanks for looking into it.

Sorry for the confusion.  The point of my question was an example of a
way to make sure the internal API stays easy to understand.  But it
seems to have backfired, and this is a small enough isolated change
that I think it's okay to say "let's clean it up later".

> Will release a v4 in just a moment with that single change reverted.


  reply	other threads:[~2013-07-18 19:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-07  4:20 [PATCH v3 0/2] allow git-svn fetching to work using serf Kyle J. McKay
2013-07-07  4:20 ` [PATCH v3 1/2] add new temp_is_locked function Kyle J. McKay
2013-07-18 18:34   ` David Rothenberger
2013-07-18 19:14     ` Kyle J. McKay
2013-07-18 19:35       ` Jonathan Nieder [this message]
2013-07-07  4:20 ` [PATCH v3 2/2] git-svn: allow git-svn fetching to work using serf Kyle J. McKay
2013-07-08 16:22 ` [PATCH v3 0/2] " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [PATCH v3 1/2] add new temp_is_locked function' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ \
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
 note: .onion URLs require Tor:

code repositories for project(s) associated with this inbox:

AGPL code for this site: git clone