list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: "Kyle J. McKay" <>
Cc:, David Rothenberger <>,
	Petr Baudis <>, Daniel Shahaf <>,
	Jonathan Nieder <>,
	Eric Wong <>
Subject: Re: [PATCH v3 0/2] allow git-svn fetching to work using serf
Date: Mon, 08 Jul 2013 09:22:23 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Kyle J. McKay's message of "Sat, 6 Jul 2013 21:20:47 -0700")

"Kyle J. McKay" <> writes:

> From: "Kyle J. McKay" <>
> This patch allows git-svn to fetch successfully using the
> serf library when given an https?: url to fetch from.
> Unfortunately some svn servers do not seem to be configured
> well for use with the serf library.  This can cause fetching
> to take longer compared to the neon library or actually
> cause timeouts during the fetch.  When timeouts occur
> git-svn can be safely restarted to fetch more revisions.
> A new temp_is_locked function has been added to
> to facilitate using the minimal number of temp files
> possible when using serf.
> The problem that occurs when running git-svn fetch using
> the serf library is that the previously used temp file
> is not always unlocked before the next temp file needs
> to be used.
> To work around this problem, a new temp name is used
> if the temp name that would otherwise be chosen is
> currently locked.
> Version v2 of the patch introduced a bug when changing the _temp_cache
> function to use the new temp_is_locked function at the suggestion of a
> reviewer.  That has now been resolved.

Thanks; I've queued this version to 'pu' at least tentatively.

Is everybody who discussed the issue happy with the direction of
this patch?

      parent reply	other threads:[~2013-07-08 16:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-07  4:20 Kyle J. McKay
2013-07-07  4:20 ` [PATCH v3 1/2] add new temp_is_locked function Kyle J. McKay
2013-07-18 18:34   ` David Rothenberger
2013-07-18 19:14     ` Kyle J. McKay
2013-07-18 19:35       ` Jonathan Nieder
2013-07-07  4:20 ` [PATCH v3 2/2] git-svn: allow git-svn fetching to work using serf Kyle J. McKay
2013-07-08 16:22 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v3 0/2] allow git-svn fetching to work using serf' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ \
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
 note: .onion URLs require Tor:

code repositories for project(s) associated with this inbox:

AGPL code for this site: git clone