From: Junio C Hamano <gitster@pobox.com>
To: "Kyle J. McKay" <mackyle@gmail.com>
Cc: git@vger.kernel.org, David Rothenberger <daveroth@acm.org>,
Petr Baudis <pasky@ucw.cz>, Daniel Shahaf <danielsh@apache.org>,
Jonathan Nieder <jrnieder@gmail.com>,
Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH v3 0/2] allow git-svn fetching to work using serf
Date: Mon, 08 Jul 2013 09:22:23 -0700 [thread overview]
Message-ID: <7vip0l10ow.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1373170849-9150-1-git-send-email-mackyle@gmail.com> (Kyle J. McKay's message of "Sat, 6 Jul 2013 21:20:47 -0700")
"Kyle J. McKay" <mackyle@gmail.com> writes:
> From: "Kyle J. McKay" <mackyle@gmail.com>
>
> This patch allows git-svn to fetch successfully using the
> serf library when given an https?: url to fetch from.
>
> Unfortunately some svn servers do not seem to be configured
> well for use with the serf library. This can cause fetching
> to take longer compared to the neon library or actually
> cause timeouts during the fetch. When timeouts occur
> git-svn can be safely restarted to fetch more revisions.
>
> A new temp_is_locked function has been added to Git.pm
> to facilitate using the minimal number of temp files
> possible when using serf.
>
> The problem that occurs when running git-svn fetch using
> the serf library is that the previously used temp file
> is not always unlocked before the next temp file needs
> to be used.
>
> To work around this problem, a new temp name is used
> if the temp name that would otherwise be chosen is
> currently locked.
>
> Version v2 of the patch introduced a bug when changing the _temp_cache
> function to use the new temp_is_locked function at the suggestion of a
> reviewer. That has now been resolved.
Thanks; I've queued this version to 'pu' at least tentatively.
Is everybody who discussed the issue happy with the direction of
this patch?
prev parent reply other threads:[~2013-07-08 16:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 4:20 [PATCH v3 0/2] allow git-svn fetching to work using serf Kyle J. McKay
2013-07-07 4:20 ` [PATCH v3 1/2] Git.pm: add new temp_is_locked function Kyle J. McKay
2013-07-18 18:34 ` David Rothenberger
2013-07-18 19:14 ` Kyle J. McKay
2013-07-18 19:35 ` Jonathan Nieder
2013-07-07 4:20 ` [PATCH v3 2/2] git-svn: allow git-svn fetching to work using serf Kyle J. McKay
2013-07-08 16:22 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vip0l10ow.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=danielsh@apache.org \
--cc=daveroth@acm.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=mackyle@gmail.com \
--cc=normalperson@yhbt.net \
--cc=pasky@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).