From: "Kyle J. McKay" <mackyle@gmail.com>
To: git@vger.kernel.org
Cc: David Rothenberger <daveroth@acm.org>, Petr Baudis <pasky@ucw.cz>,
Daniel Shahaf <danielsh@apache.org>,
Jonathan Nieder <jrnieder@gmail.com>,
Eric Wong <normalperson@yhbt.net>
Subject: [PATCH v3 1/2] Git.pm: add new temp_is_locked function
Date: Sat, 6 Jul 2013 21:20:48 -0700 [thread overview]
Message-ID: <1373170849-9150-2-git-send-email-mackyle@gmail.com> (raw)
In-Reply-To: <1373170849-9150-1-git-send-email-mackyle@gmail.com>
From: "Kyle J. McKay" <mackyle@gmail.com>
The temp_is_locked function can be used to determine whether
or not a given name previously passed to temp_acquire is
currently locked.
Signed-off-by: Kyle J. McKay <mackyle@gmail.com>
---
perl/Git.pm | 33 +++++++++++++++++++++++++++++++--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git a/perl/Git.pm b/perl/Git.pm
index 7a252ef..0ba15b9 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -61,7 +61,7 @@ require Exporter;
remote_refs prompt
get_tz_offset
credential credential_read credential_write
- temp_acquire temp_release temp_reset temp_path);
+ temp_acquire temp_is_locked temp_release temp_reset temp_path);
=head1 DESCRIPTION
@@ -1206,6 +1206,35 @@ sub temp_acquire {
$temp_fd;
}
+=item temp_is_locked ( NAME )
+
+Returns true if the internal lock created by a previous C<temp_acquire()>
+call with C<NAME> is still in effect.
+
+When temp_acquire is called on a C<NAME>, it internally locks the temporary
+file mapped to C<NAME>. That lock will not be released until C<temp_release()>
+is called with either the original C<NAME> or the L<File::Handle> that was
+returned from the original call to temp_acquire.
+
+Subsequent attempts to call C<temp_acquire()> with the same C<NAME> will fail
+unless there has been an intervening C<temp_release()> call for that C<NAME>
+(or its corresponding L<File::Handle> that was returned by the original
+C<temp_acquire()> call).
+
+If true is returned by C<temp_is_locked()> for a C<NAME>, an attempt to
+C<temp_acquire()> the same C<NAME> will cause an error unless
+C<temp_release> is first called on that C<NAME> (or its corresponding
+L<File::Handle> that was returned by the original C<temp_acquire()> call).
+
+=cut
+
+sub temp_is_locked {
+ my ($self, $name) = _maybe_self(@_);
+ my $temp_fd = \$TEMP_FILEMAP{$name};
+
+ defined $$temp_fd && $$temp_fd->opened && $TEMP_FILES{$$temp_fd}{locked};
+}
+
=item temp_release ( NAME )
=item temp_release ( FILEHANDLE )
@@ -1248,7 +1277,7 @@ sub _temp_cache {
my $temp_fd = \$TEMP_FILEMAP{$name};
if (defined $$temp_fd and $$temp_fd->opened) {
- if ($TEMP_FILES{$$temp_fd}{locked}) {
+ if (temp_is_locked($name)) {
throw Error::Simple("Temp file with moniker '" .
$name . "' already in use");
}
--
1.8.3
next prev parent reply other threads:[~2013-07-07 4:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 4:20 [PATCH v3 0/2] allow git-svn fetching to work using serf Kyle J. McKay
2013-07-07 4:20 ` Kyle J. McKay [this message]
2013-07-18 18:34 ` [PATCH v3 1/2] Git.pm: add new temp_is_locked function David Rothenberger
2013-07-18 19:14 ` Kyle J. McKay
2013-07-18 19:35 ` Jonathan Nieder
2013-07-07 4:20 ` [PATCH v3 2/2] git-svn: allow git-svn fetching to work using serf Kyle J. McKay
2013-07-08 16:22 ` [PATCH v3 0/2] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373170849-9150-2-git-send-email-mackyle@gmail.com \
--to=mackyle@gmail.com \
--cc=danielsh@apache.org \
--cc=daveroth@acm.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=normalperson@yhbt.net \
--cc=pasky@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).