git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH v2] commit: Fix description of no-verify
       [not found] <alpine.DEB.2.20.1607261541170.14111>
@ 2016-07-26 14:00 ` orgads
  2016-07-26 20:44   ` Junio C Hamano
  0 siblings, 1 reply; 2+ messages in thread
From: orgads @ 2016-07-26 14:00 UTC (permalink / raw)
  To: git; +Cc: Orgad Shaneh

From: Orgad Shaneh <orgads@gmail.com>

include also commit-msg hook.

This brings the short help in line with the documentation.

Signed-off-by: Orgad Shaneh <orgads@gmail.com>
---
 builtin/commit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/commit.c b/builtin/commit.c
index 163dbca..2725712 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -1616,7 +1616,7 @@ int cmd_commit(int argc, const char **argv, const char *prefix)
 		OPT_BOOL(0, "interactive", &interactive, N_("interactively add files")),
 		OPT_BOOL('p', "patch", &patch_interactive, N_("interactively add changes")),
 		OPT_BOOL('o', "only", &only, N_("commit only specified files")),
-		OPT_BOOL('n', "no-verify", &no_verify, N_("bypass pre-commit hook")),
+		OPT_BOOL('n', "no-verify", &no_verify, N_("bypass pre-commit and commit-msg hooks")),
 		OPT_BOOL(0, "dry-run", &dry_run, N_("show what would be committed")),
 		OPT_SET_INT(0, "short", &status_format, N_("show status concisely"),
 			    STATUS_FORMAT_SHORT),
-- 
2.8.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] commit: Fix description of no-verify
  2016-07-26 14:00 ` [PATCH v2] commit: Fix description of no-verify orgads
@ 2016-07-26 20:44   ` Junio C Hamano
  0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2016-07-26 20:44 UTC (permalink / raw)
  To: orgads; +Cc: git

orgads@gmail.com writes:

> Subject: Re: [PATCH v2] commit: Fix description of no-verify

Following the prevailing style from "git shortlog --no-merges -100"
would make it "commit: fix description of no-verify", but "fix" is
too generic a word and does not convey as much information as it
wastes bits ;-)

    Subject: commit: --no-verify option skips commit-msg hook, too

perhaps?

> From: Orgad Shaneh <orgads@gmail.com>
>
> include also commit-msg hook.

Then this half-sentence can go completely.

Thanks; I'll do the above myself while queuing, so there is no need
to resend.

> diff --git a/builtin/commit.c b/builtin/commit.c
> index 163dbca..2725712 100644
> --- a/builtin/commit.c
> +++ b/builtin/commit.c
> @@ -1616,7 +1616,7 @@ int cmd_commit(int argc, const char **argv, const char *prefix)
>  		OPT_BOOL(0, "interactive", &interactive, N_("interactively add files")),
>  		OPT_BOOL('p', "patch", &patch_interactive, N_("interactively add changes")),
>  		OPT_BOOL('o', "only", &only, N_("commit only specified files")),
> -		OPT_BOOL('n', "no-verify", &no_verify, N_("bypass pre-commit hook")),
> +		OPT_BOOL('n', "no-verify", &no_verify, N_("bypass pre-commit and commit-msg hooks")),
>  		OPT_BOOL(0, "dry-run", &dry_run, N_("show what would be committed")),
>  		OPT_SET_INT(0, "short", &status_format, N_("show status concisely"),
>  			    STATUS_FORMAT_SHORT),

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-07-26 20:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <alpine.DEB.2.20.1607261541170.14111>
2016-07-26 14:00 ` [PATCH v2] commit: Fix description of no-verify orgads
2016-07-26 20:44   ` Junio C Hamano

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).