From: Junio C Hamano <gitster@pobox.com>
To: orgads@gmail.com
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] commit: Fix description of no-verify
Date: Tue, 26 Jul 2016 13:44:01 -0700 [thread overview]
Message-ID: <xmqqoa5kyvse.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1469541615-21726-1-git-send-email-orgads@gmail.com> (orgads@gmail.com's message of "Tue, 26 Jul 2016 17:00:15 +0300")
orgads@gmail.com writes:
> Subject: Re: [PATCH v2] commit: Fix description of no-verify
Following the prevailing style from "git shortlog --no-merges -100"
would make it "commit: fix description of no-verify", but "fix" is
too generic a word and does not convey as much information as it
wastes bits ;-)
Subject: commit: --no-verify option skips commit-msg hook, too
perhaps?
> From: Orgad Shaneh <orgads@gmail.com>
>
> include also commit-msg hook.
Then this half-sentence can go completely.
Thanks; I'll do the above myself while queuing, so there is no need
to resend.
> diff --git a/builtin/commit.c b/builtin/commit.c
> index 163dbca..2725712 100644
> --- a/builtin/commit.c
> +++ b/builtin/commit.c
> @@ -1616,7 +1616,7 @@ int cmd_commit(int argc, const char **argv, const char *prefix)
> OPT_BOOL(0, "interactive", &interactive, N_("interactively add files")),
> OPT_BOOL('p', "patch", &patch_interactive, N_("interactively add changes")),
> OPT_BOOL('o', "only", &only, N_("commit only specified files")),
> - OPT_BOOL('n', "no-verify", &no_verify, N_("bypass pre-commit hook")),
> + OPT_BOOL('n', "no-verify", &no_verify, N_("bypass pre-commit and commit-msg hooks")),
> OPT_BOOL(0, "dry-run", &dry_run, N_("show what would be committed")),
> OPT_SET_INT(0, "short", &status_format, N_("show status concisely"),
> STATUS_FORMAT_SHORT),
prev parent reply other threads:[~2016-07-26 20:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.20.1607261541170.14111>
2016-07-26 14:00 ` [PATCH v2] commit: Fix description of no-verify orgads
2016-07-26 20:44 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoa5kyvse.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=orgads@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).