* [PATCH] i18n: proposed command missing leading dash
@ 2014-02-28 20:52 Sandy Carter
2014-02-28 21:41 ` Jonathan Nieder
2014-03-03 14:55 ` [PATCH v2 1/2] " Sandy Carter
0 siblings, 2 replies; 11+ messages in thread
From: Sandy Carter @ 2014-02-28 20:52 UTC (permalink / raw)
To: git; +Cc: Sandy Carter, jn.avila
Add missing leading dash to proposed commands in french output when
using the command:
git branch --set-upstream remotename/branchname
Signed-off-by: Sandy Carter <sandy.carter@savoirfairelinux.com>
---
po/fr.po | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/po/fr.po b/po/fr.po
index e10263f..7b44229 100644
--- a/po/fr.po
+++ b/po/fr.po
@@ -3266,7 +3266,7 @@ msgstr " git branch -d %s\n"
#: builtin/branch.c:1027
#, c-format
msgid " git branch --set-upstream-to %s\n"
-msgstr " git branch -set-upstream-to %s\n"
+msgstr " git branch --set-upstream-to %s\n"
#: builtin/bundle.c:47
#, c-format
--
1.9.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] i18n: proposed command missing leading dash
2014-02-28 20:52 [PATCH] i18n: proposed command missing leading dash Sandy Carter
@ 2014-02-28 21:41 ` Jonathan Nieder
2014-02-28 23:31 ` Junio C Hamano
2014-03-03 14:55 ` [PATCH v2 1/2] " Sandy Carter
1 sibling, 1 reply; 11+ messages in thread
From: Jonathan Nieder @ 2014-02-28 21:41 UTC (permalink / raw)
To: Sandy Carter; +Cc: git, jn.avila, Carlos Martín Nieto
Hi,
Sandy Carter wrote:
> Add missing leading dash to proposed commands in french output when
> using the command:
Thanks!
[...]
> --- a/po/fr.po
> +++ b/po/fr.po
> @@ -3266,7 +3266,7 @@ msgstr " git branch -d %s\n"
> #: builtin/branch.c:1027
> #, c-format
> msgid " git branch --set-upstream-to %s\n"
> -msgstr " git branch -set-upstream-to %s\n"
> +msgstr " git branch --set-upstream-to %s\n"
To make life saner for translators, this should be either
untranslatable or a single multi-line string, I suspect:
diff --git i/builtin/branch.c w/builtin/branch.c
index b4d7716..972040c 100644
--- i/builtin/branch.c
+++ w/builtin/branch.c
@@ -1022,11 +1022,13 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
*/
if (argc == 1 && track == BRANCH_TRACK_OVERRIDE &&
!branch_existed && remote_tracking) {
- fprintf(stderr, _("\nIf you wanted to make '%s' track '%s', do this:\n\n"), head, branch->name);
- fprintf(stderr, _(" git branch -d %s\n"), branch->name);
- fprintf(stderr, _(" git branch --set-upstream-to %s\n"), branch->name);
+ fprintf(stderr, "\n");
+ fprintf(stderr, _("If you wanted to make '%s' track '%s', do this:\n\n"
+ " git branch -d %s\n"
+ " git branch --set-upstream-to %s"),
+ head, branch->name, branch->name, branch->name);
+ fprintf(stderr, "\n");
}
-
} else
usage_with_options(builtin_branch_usage, options);
What do you think?
Jonathan
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] i18n: proposed command missing leading dash
2014-02-28 21:41 ` Jonathan Nieder
@ 2014-02-28 23:31 ` Junio C Hamano
2014-03-01 0:36 ` Sandy Carter
0 siblings, 1 reply; 11+ messages in thread
From: Junio C Hamano @ 2014-02-28 23:31 UTC (permalink / raw)
To: Jonathan Nieder; +Cc: Sandy Carter, git, jn.avila, Carlos Martín Nieto
Jonathan Nieder <jrnieder@gmail.com> writes:
> To make life saner for translators, this should be either
> untranslatable or a single multi-line string, I suspect:
>
> diff --git i/builtin/branch.c w/builtin/branch.c
> index b4d7716..972040c 100644
> --- i/builtin/branch.c
> +++ w/builtin/branch.c
> @@ -1022,11 +1022,13 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
> */
> if (argc == 1 && track == BRANCH_TRACK_OVERRIDE &&
> !branch_existed && remote_tracking) {
> - fprintf(stderr, _("\nIf you wanted to make '%s' track '%s', do this:\n\n"), head, branch->name);
> - fprintf(stderr, _(" git branch -d %s\n"), branch->name);
> - fprintf(stderr, _(" git branch --set-upstream-to %s\n"), branch->name);
> + fprintf(stderr, "\n");
> + fprintf(stderr, _("If you wanted to make '%s' track '%s', do this:\n\n"
> + " git branch -d %s\n"
> + " git branch --set-upstream-to %s"),
> + head, branch->name, branch->name, branch->name);
> + fprintf(stderr, "\n");
> }
> -
> } else
> usage_with_options(builtin_branch_usage, options);
>
> What do you think?
Yes, I think it is sensible to make sure that the command examples
are not corrupted by the _() process.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] i18n: proposed command missing leading dash
2014-02-28 23:31 ` Junio C Hamano
@ 2014-03-01 0:36 ` Sandy Carter
0 siblings, 0 replies; 11+ messages in thread
From: Sandy Carter @ 2014-03-01 0:36 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, jn avila, Carlos Martín Nieto, Jonathan Nieder
Should I also update the relevant git.pot and *.po sections?
----- Original Message -----
From: "Junio C Hamano" <gitster@pobox.com>
To: "Jonathan Nieder" <jrnieder@gmail.com>
Cc: "Sandy Carter" <sandy.carter@savoirfairelinux.com>, git@vger.kernel.org, "jn avila" <jn.avila@free.fr>, "Carlos Martín Nieto" <cmn@elego.de>
Sent: Friday, February 28, 2014 6:31:32 PM
Subject: Re: [PATCH] i18n: proposed command missing leading dash
Jonathan Nieder <jrnieder@gmail.com> writes:
> To make life saner for translators, this should be either
> untranslatable or a single multi-line string, I suspect:
>
> diff --git i/builtin/branch.c w/builtin/branch.c
> index b4d7716..972040c 100644
> --- i/builtin/branch.c
> +++ w/builtin/branch.c
> @@ -1022,11 +1022,13 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
> */
> if (argc == 1 && track == BRANCH_TRACK_OVERRIDE &&
> !branch_existed && remote_tracking) {
> - fprintf(stderr, _("\nIf you wanted to make '%s' track '%s', do this:\n\n"), head, branch->name);
> - fprintf(stderr, _(" git branch -d %s\n"), branch->name);
> - fprintf(stderr, _(" git branch --set-upstream-to %s\n"), branch->name);
> + fprintf(stderr, "\n");
> + fprintf(stderr, _("If you wanted to make '%s' track '%s', do this:\n\n"
> + " git branch -d %s\n"
> + " git branch --set-upstream-to %s"),
> + head, branch->name, branch->name, branch->name);
> + fprintf(stderr, "\n");
> }
> -
> } else
> usage_with_options(builtin_branch_usage, options);
>
> What do you think?
Yes, I think it is sensible to make sure that the command examples
are not corrupted by the _() process.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 1/2] i18n: proposed command missing leading dash
2014-02-28 20:52 [PATCH] i18n: proposed command missing leading dash Sandy Carter
2014-02-28 21:41 ` Jonathan Nieder
@ 2014-03-03 14:55 ` Sandy Carter
2014-03-03 14:55 ` [PATCH v2 2/2] i18n: assure command not corrupted by _() process Sandy Carter
2014-03-04 18:40 ` [PATCH v2 1/2] i18n: proposed command missing leading dash Junio C Hamano
1 sibling, 2 replies; 11+ messages in thread
From: Sandy Carter @ 2014-03-03 14:55 UTC (permalink / raw)
To: git; +Cc: jn.avila, Sandy Carter
Add missing leading dash to proposed commands in french output when
using the command:
git branch --set-upstream remotename/branchname
and when upstream is gone
Signed-off-by: Sandy Carter <sandy.carter@savoirfairelinux.com>
---
po/fr.po | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/po/fr.po b/po/fr.po
index e10263f..0b9d59e 100644
--- a/po/fr.po
+++ b/po/fr.po
@@ -1075,7 +1075,7 @@ msgstr "Votre branche est basée sur '%s', mais la branche amont a disparu.\n"
#: remote.c:1875
msgid " (use \"git branch --unset-upstream\" to fixup)\n"
-msgstr " (utilisez \"git branch -unset-upstream\" pour corriger)\n"
+msgstr " (utilisez \"git branch --unset-upstream\" pour corriger)\n"
#: remote.c:1878
#, c-format
@@ -3266,7 +3266,7 @@ msgstr " git branch -d %s\n"
#: builtin/branch.c:1027
#, c-format
msgid " git branch --set-upstream-to %s\n"
-msgstr " git branch -set-upstream-to %s\n"
+msgstr " git branch --set-upstream-to %s\n"
#: builtin/bundle.c:47
#, c-format
--
1.9.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 2/2] i18n: assure command not corrupted by _() process
2014-03-03 14:55 ` [PATCH v2 1/2] " Sandy Carter
@ 2014-03-03 14:55 ` Sandy Carter
2014-03-10 12:51 ` Sandy Carter
2014-03-04 18:40 ` [PATCH v2 1/2] i18n: proposed command missing leading dash Junio C Hamano
1 sibling, 1 reply; 11+ messages in thread
From: Sandy Carter @ 2014-03-03 14:55 UTC (permalink / raw)
To: git; +Cc: jn.avila, Sandy Carter
Separate message from command examples to avoid translation issues
such as a dash being omitted in a translation.
Signed-off-by: Sandy Carter <sandy.carter@savoirfairelinux.com>
---
builtin/branch.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/builtin/branch.c b/builtin/branch.c
index b4d7716..b304da8 100644
--- a/builtin/branch.c
+++ b/builtin/branch.c
@@ -1022,11 +1022,13 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
*/
if (argc == 1 && track == BRANCH_TRACK_OVERRIDE &&
!branch_existed && remote_tracking) {
- fprintf(stderr, _("\nIf you wanted to make '%s' track '%s', do this:\n\n"), head, branch->name);
- fprintf(stderr, _(" git branch -d %s\n"), branch->name);
- fprintf(stderr, _(" git branch --set-upstream-to %s\n"), branch->name);
+ fprintf(stderr, "\n");
+ fprintf(stderr, _("If you wanted to make '%s' track '%s', do this:"), head, branch->name);
+ fprintf(stderr, "\n\n");
+ fprintf(stderr, " git branch -d %s\n", branch->name);
+ fprintf(stderr, " git branch --set-upstream-to %s\n", branch->name);
+ fprintf(stderr, "\n");
}
-
} else
usage_with_options(builtin_branch_usage, options);
--
1.9.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] i18n: proposed command missing leading dash
2014-03-03 14:55 ` [PATCH v2 1/2] " Sandy Carter
2014-03-03 14:55 ` [PATCH v2 2/2] i18n: assure command not corrupted by _() process Sandy Carter
@ 2014-03-04 18:40 ` Junio C Hamano
2014-03-05 14:14 ` Jiang Xin
1 sibling, 1 reply; 11+ messages in thread
From: Junio C Hamano @ 2014-03-04 18:40 UTC (permalink / raw)
To: Jiang Xin; +Cc: git, jn.avila, Sandy Carter
From: Sandy Carter <sandy.carter@savoirfairelinux.com>
Date: Mon, 3 Mar 2014 09:55:53 -0500
Add missing leading dash to proposed commands in french output when
using the command:
git branch --set-upstream remotename/branchname
and when upstream is gone
Signed-off-by: Sandy Carter <sandy.carter@savoirfairelinux.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
* Forwarding to the i18n coordinator. I don't do French, but this
seems trivially correct.
po/fr.po | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/po/fr.po b/po/fr.po
index e10263f..0b9d59e 100644
--- a/po/fr.po
+++ b/po/fr.po
@@ -1075,7 +1075,7 @@ msgstr "Votre branche est basée sur '%s', mais la branche amont a disparu.\n"
#: remote.c:1875
msgid " (use \"git branch --unset-upstream\" to fixup)\n"
-msgstr " (utilisez \"git branch -unset-upstream\" pour corriger)\n"
+msgstr " (utilisez \"git branch --unset-upstream\" pour corriger)\n"
#: remote.c:1878
#, c-format
@@ -3266,7 +3266,7 @@ msgstr " git branch -d %s\n"
#: builtin/branch.c:1027
#, c-format
msgid " git branch --set-upstream-to %s\n"
-msgstr " git branch -set-upstream-to %s\n"
+msgstr " git branch --set-upstream-to %s\n"
#: builtin/bundle.c:47
#, c-format
--
1.9.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] i18n: proposed command missing leading dash
2014-03-04 18:40 ` [PATCH v2 1/2] i18n: proposed command missing leading dash Junio C Hamano
@ 2014-03-05 14:14 ` Jiang Xin
2014-03-05 21:57 ` Junio C Hamano
0 siblings, 1 reply; 11+ messages in thread
From: Jiang Xin @ 2014-03-05 14:14 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Git List, Jean-Noel Avila, Sandy Carter
2014-03-05 2:40 GMT+08:00 Junio C Hamano <gitster@pobox.com>:
> From: Sandy Carter <sandy.carter@savoirfairelinux.com>
> Date: Mon, 3 Mar 2014 09:55:53 -0500
>
> Add missing leading dash to proposed commands in french output when
> using the command:
> git branch --set-upstream remotename/branchname
> and when upstream is gone
>
> Signed-off-by: Sandy Carter <sandy.carter@savoirfairelinux.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>
> * Forwarding to the i18n coordinator. I don't do French, but this
> seems trivially correct.
Applied to maint branch of git://github.com/git-l10n/git-po, and can be
merged to master directly.
--
Jiang Xin
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] i18n: proposed command missing leading dash
2014-03-05 14:14 ` Jiang Xin
@ 2014-03-05 21:57 ` Junio C Hamano
0 siblings, 0 replies; 11+ messages in thread
From: Junio C Hamano @ 2014-03-05 21:57 UTC (permalink / raw)
To: Jiang Xin; +Cc: Git List, Jean-Noel Avila, Sandy Carter
Jiang Xin <worldhello.net@gmail.com> writes:
> 2014-03-05 2:40 GMT+08:00 Junio C Hamano <gitster@pobox.com>:
>> From: Sandy Carter <sandy.carter@savoirfairelinux.com>
>> Date: Mon, 3 Mar 2014 09:55:53 -0500
>>
>> Add missing leading dash to proposed commands in french output when
>> using the command:
>> git branch --set-upstream remotename/branchname
>> and when upstream is gone
>>
>> Signed-off-by: Sandy Carter <sandy.carter@savoirfairelinux.com>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>> ---
>>
>> * Forwarding to the i18n coordinator. I don't do French, but this
>> seems trivially correct.
>
> Applied to maint branch of git://github.com/git-l10n/git-po, and can be
> merged to master directly.
Thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/2] i18n: assure command not corrupted by _() process
2014-03-03 14:55 ` [PATCH v2 2/2] i18n: assure command not corrupted by _() process Sandy Carter
@ 2014-03-10 12:51 ` Sandy Carter
2014-03-11 11:40 ` Duy Nguyen
0 siblings, 1 reply; 11+ messages in thread
From: Sandy Carter @ 2014-03-10 12:51 UTC (permalink / raw)
To: git; +Cc: jn.avila
Is there any update on this patch?
Le 2014-03-03 09:55, Sandy Carter a écrit :
> Separate message from command examples to avoid translation issues
> such as a dash being omitted in a translation.
>
> Signed-off-by: Sandy Carter <sandy.carter@savoirfairelinux.com>
> ---
> builtin/branch.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/builtin/branch.c b/builtin/branch.c
> index b4d7716..b304da8 100644
> --- a/builtin/branch.c
> +++ b/builtin/branch.c
> @@ -1022,11 +1022,13 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
> */
> if (argc == 1 && track == BRANCH_TRACK_OVERRIDE &&
> !branch_existed && remote_tracking) {
> - fprintf(stderr, _("\nIf you wanted to make '%s' track '%s', do this:\n\n"), head, branch->name);
> - fprintf(stderr, _(" git branch -d %s\n"), branch->name);
> - fprintf(stderr, _(" git branch --set-upstream-to %s\n"), branch->name);
> + fprintf(stderr, "\n");
> + fprintf(stderr, _("If you wanted to make '%s' track '%s', do this:"), head, branch->name);
> + fprintf(stderr, "\n\n");
> + fprintf(stderr, " git branch -d %s\n", branch->name);
> + fprintf(stderr, " git branch --set-upstream-to %s\n", branch->name);
> + fprintf(stderr, "\n");
> }
> -
> } else
> usage_with_options(builtin_branch_usage, options);
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/2] i18n: assure command not corrupted by _() process
2014-03-10 12:51 ` Sandy Carter
@ 2014-03-11 11:40 ` Duy Nguyen
0 siblings, 0 replies; 11+ messages in thread
From: Duy Nguyen @ 2014-03-11 11:40 UTC (permalink / raw)
To: Sandy Carter; +Cc: Git Mailing List, jn.avila, Junio C Hamano
On Mon, Mar 10, 2014 at 7:51 PM, Sandy Carter
<sandy.carter@savoirfairelinux.com> wrote:
> Is there any update on this patch?
The patch looks good. Maybe Junio missed it.
>
> Le 2014-03-03 09:55, Sandy Carter a écrit :
>
>> Separate message from command examples to avoid translation issues
>> such as a dash being omitted in a translation.
>>
>> Signed-off-by: Sandy Carter <sandy.carter@savoirfairelinux.com>
>> ---
>> builtin/branch.c | 10 ++++++----
>> 1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/builtin/branch.c b/builtin/branch.c
>> index b4d7716..b304da8 100644
>> --- a/builtin/branch.c
>> +++ b/builtin/branch.c
>> @@ -1022,11 +1022,13 @@ int cmd_branch(int argc, const char **argv, const
>> char *prefix)
>> */
>> if (argc == 1 && track == BRANCH_TRACK_OVERRIDE &&
>> !branch_existed && remote_tracking) {
>> - fprintf(stderr, _("\nIf you wanted to make '%s'
>> track '%s', do this:\n\n"), head, branch->name);
>> - fprintf(stderr, _(" git branch -d %s\n"),
>> branch->name);
>> - fprintf(stderr, _(" git branch
>> --set-upstream-to %s\n"), branch->name);
>> + fprintf(stderr, "\n");
>> + fprintf(stderr, _("If you wanted to make '%s'
>> track '%s', do this:"), head, branch->name);
>> + fprintf(stderr, "\n\n");
>> + fprintf(stderr, " git branch -d %s\n",
>> branch->name);
>> + fprintf(stderr, " git branch --set-upstream-to
>> %s\n", branch->name);
>> + fprintf(stderr, "\n");
>> }
>> -
>> } else
>> usage_with_options(builtin_branch_usage, options);
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Duy
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2014-03-11 11:41 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-28 20:52 [PATCH] i18n: proposed command missing leading dash Sandy Carter
2014-02-28 21:41 ` Jonathan Nieder
2014-02-28 23:31 ` Junio C Hamano
2014-03-01 0:36 ` Sandy Carter
2014-03-03 14:55 ` [PATCH v2 1/2] " Sandy Carter
2014-03-03 14:55 ` [PATCH v2 2/2] i18n: assure command not corrupted by _() process Sandy Carter
2014-03-10 12:51 ` Sandy Carter
2014-03-11 11:40 ` Duy Nguyen
2014-03-04 18:40 ` [PATCH v2 1/2] i18n: proposed command missing leading dash Junio C Hamano
2014-03-05 14:14 ` Jiang Xin
2014-03-05 21:57 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).