From: Sandy Carter <sandy.carter@savoirfairelinux.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "jn avila" <jn.avila@free.fr>,
"Carlos Martín Nieto" <cmn@elego.de>,
"Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: [PATCH] i18n: proposed command missing leading dash
Date: Fri, 28 Feb 2014 19:36:16 -0500 (EST) [thread overview]
Message-ID: <1960754503.587182.1393634176189.JavaMail.root@mail> (raw)
In-Reply-To: <xmqq38j2u84r.fsf@gitster.dls.corp.google.com>
Should I also update the relevant git.pot and *.po sections?
----- Original Message -----
From: "Junio C Hamano" <gitster@pobox.com>
To: "Jonathan Nieder" <jrnieder@gmail.com>
Cc: "Sandy Carter" <sandy.carter@savoirfairelinux.com>, git@vger.kernel.org, "jn avila" <jn.avila@free.fr>, "Carlos Martín Nieto" <cmn@elego.de>
Sent: Friday, February 28, 2014 6:31:32 PM
Subject: Re: [PATCH] i18n: proposed command missing leading dash
Jonathan Nieder <jrnieder@gmail.com> writes:
> To make life saner for translators, this should be either
> untranslatable or a single multi-line string, I suspect:
>
> diff --git i/builtin/branch.c w/builtin/branch.c
> index b4d7716..972040c 100644
> --- i/builtin/branch.c
> +++ w/builtin/branch.c
> @@ -1022,11 +1022,13 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
> */
> if (argc == 1 && track == BRANCH_TRACK_OVERRIDE &&
> !branch_existed && remote_tracking) {
> - fprintf(stderr, _("\nIf you wanted to make '%s' track '%s', do this:\n\n"), head, branch->name);
> - fprintf(stderr, _(" git branch -d %s\n"), branch->name);
> - fprintf(stderr, _(" git branch --set-upstream-to %s\n"), branch->name);
> + fprintf(stderr, "\n");
> + fprintf(stderr, _("If you wanted to make '%s' track '%s', do this:\n\n"
> + " git branch -d %s\n"
> + " git branch --set-upstream-to %s"),
> + head, branch->name, branch->name, branch->name);
> + fprintf(stderr, "\n");
> }
> -
> } else
> usage_with_options(builtin_branch_usage, options);
>
> What do you think?
Yes, I think it is sensible to make sure that the command examples
are not corrupted by the _() process.
next prev parent reply other threads:[~2014-03-01 0:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 20:52 [PATCH] i18n: proposed command missing leading dash Sandy Carter
2014-02-28 21:41 ` Jonathan Nieder
2014-02-28 23:31 ` Junio C Hamano
2014-03-01 0:36 ` Sandy Carter [this message]
2014-03-03 14:55 ` [PATCH v2 1/2] " Sandy Carter
2014-03-03 14:55 ` [PATCH v2 2/2] i18n: assure command not corrupted by _() process Sandy Carter
2014-03-10 12:51 ` Sandy Carter
2014-03-11 11:40 ` Duy Nguyen
2014-03-04 18:40 ` [PATCH v2 1/2] i18n: proposed command missing leading dash Junio C Hamano
2014-03-05 14:14 ` Jiang Xin
2014-03-05 21:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1960754503.587182.1393634176189.JavaMail.root@mail \
--to=sandy.carter@savoirfairelinux.com \
--cc=cmn@elego.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jn.avila@free.fr \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).