* [PATCH] test-lib.sh: unfilter GIT_PERF_*
@ 2013-01-15 12:53 Nguyễn Thái Ngọc Duy
2013-01-15 13:43 ` Thomas Rast
2013-01-15 13:50 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
0 siblings, 2 replies; 7+ messages in thread
From: Nguyễn Thái Ngọc Duy @ 2013-01-15 12:53 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Thomas Rast,
Nguyễn Thái Ngọc Duy
These variables are user parameters to control how to run the perf
tests. Allow users to do so.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
t/test-lib.sh | 3 +++
1 file changed, 3 insertions(+)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index f50f834..b8d35d1 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -86,6 +86,9 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e '
PROVE
VALGRIND
PERF_AGGREGATING_LATER
+ PERF_LARGE_REPO
+ PERF_REPEAT_COUNT
+ PERF_REPO
));
my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);
print join("\n", @vars);
--
1.8.0.rc2.23.g1fb49df
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] test-lib.sh: unfilter GIT_PERF_*
2013-01-15 12:53 [PATCH] test-lib.sh: unfilter GIT_PERF_* Nguyễn Thái Ngọc Duy
@ 2013-01-15 13:43 ` Thomas Rast
2013-01-15 13:47 ` Duy Nguyen
2013-01-15 13:50 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
1 sibling, 1 reply; 7+ messages in thread
From: Thomas Rast @ 2013-01-15 13:43 UTC (permalink / raw)
To: Nguyễn Thái Ngọc Duy; +Cc: git, Junio C Hamano, Thomas Rast
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> These variables are user parameters to control how to run the perf
> tests. Allow users to do so.
[...]
> @@ -86,6 +86,9 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e '
> PROVE
> VALGRIND
> PERF_AGGREGATING_LATER
> + PERF_LARGE_REPO
> + PERF_REPEAT_COUNT
> + PERF_REPO
> ));
Wouldn't it be more futureproof to put simply PERF as an entry, and rely
on the leading-match logic
> my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);
to allow all GIT_PERF variables?
Other than that, Ack. I never noticed because I set mine through
config.mak, which goes to GIT-BUILD-OPTIONS. Those options are not
exported, which means perl does not pick them up. (That just took me
far too long to realize.)
--
Thomas Rast
trast@{inf,student}.ethz.ch
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] test-lib.sh: unfilter GIT_PERF_*
2013-01-15 13:43 ` Thomas Rast
@ 2013-01-15 13:47 ` Duy Nguyen
0 siblings, 0 replies; 7+ messages in thread
From: Duy Nguyen @ 2013-01-15 13:47 UTC (permalink / raw)
To: Thomas Rast; +Cc: git, Junio C Hamano
On Tue, Jan 15, 2013 at 8:43 PM, Thomas Rast <trast@student.ethz.ch> wrote:
> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>> These variables are user parameters to control how to run the perf
>> tests. Allow users to do so.
> [...]
>> @@ -86,6 +86,9 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e '
>> PROVE
>> VALGRIND
>> PERF_AGGREGATING_LATER
>> + PERF_LARGE_REPO
>> + PERF_REPEAT_COUNT
>> + PERF_REPO
>> ));
>
> Wouldn't it be more futureproof to put simply PERF as an entry, and rely
> on the leading-match logic
>
>> my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);
>
> to allow all GIT_PERF variables?
Yeah.
> Other than that, Ack. I never noticed because I set mine through
> config.mak, which goes to GIT-BUILD-OPTIONS. Those options are not
> exported, which means perl does not pick them up. (That just took me
> far too long to realize.)
By the way is there an option to skip the first few runs (too lazy to
check out the source code, apparently)? I tried linux-2.6 as the large
repo and I think the first (cold cache) run ruins the numbers.
--
Duy
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] test-lib.sh: unfilter GIT_PERF_*
2013-01-15 12:53 [PATCH] test-lib.sh: unfilter GIT_PERF_* Nguyễn Thái Ngọc Duy
2013-01-15 13:43 ` Thomas Rast
@ 2013-01-15 13:50 ` Nguyễn Thái Ngọc Duy
2013-01-15 19:31 ` Junio C Hamano
2013-01-16 10:23 ` [PATCH v3] " Nguyễn Thái Ngọc Duy
1 sibling, 2 replies; 7+ messages in thread
From: Nguyễn Thái Ngọc Duy @ 2013-01-15 13:50 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Thomas Rast,
Nguyễn Thái Ngọc Duy
These variables are user parameters to control how to run the perf
tests. Allow users to do so.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
t/test-lib.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index f50f834..e1c8c85 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -85,7 +85,7 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e '
.*_TEST
PROVE
VALGRIND
- PERF_AGGREGATING_LATER
+ PERF
));
my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);
print join("\n", @vars);
--
1.8.0.rc2.23.g1fb49df
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] test-lib.sh: unfilter GIT_PERF_*
2013-01-15 13:50 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
@ 2013-01-15 19:31 ` Junio C Hamano
2013-01-16 10:23 ` [PATCH v3] " Nguyễn Thái Ngọc Duy
1 sibling, 0 replies; 7+ messages in thread
From: Junio C Hamano @ 2013-01-15 19:31 UTC (permalink / raw)
To: Nguyễn Thái Ngọc Duy; +Cc: git, Thomas Rast
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> These variables are user parameters to control how to run the perf
> tests. Allow users to do so.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
I think the Subject makes more sense, so I'd suggest replacing the
current one with "PERF_", not with "PERF".
> t/test-lib.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index f50f834..e1c8c85 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -85,7 +85,7 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e '
> .*_TEST
> PROVE
> VALGRIND
> - PERF_AGGREGATING_LATER
> + PERF
> ));
> my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);
> print join("\n", @vars);
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] test-lib.sh: unfilter GIT_PERF_*
2013-01-15 13:50 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2013-01-15 19:31 ` Junio C Hamano
@ 2013-01-16 10:23 ` Nguyễn Thái Ngọc Duy
2013-01-16 18:54 ` Jonathan Nieder
1 sibling, 1 reply; 7+ messages in thread
From: Nguyễn Thái Ngọc Duy @ 2013-01-16 10:23 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Thomas Rast,
Nguyễn Thái Ngọc Duy
These variables are user parameters to control how to run the perf
tests. Allow users to do so.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
PERF -> PERF_
t/test-lib.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index f50f834..bf4cf71 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -85,7 +85,7 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e '
.*_TEST
PROVE
VALGRIND
- PERF_AGGREGATING_LATER
+ PERF_
));
my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);
print join("\n", @vars);
--
1.8.0.rc2.23.g1fb49df
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3] test-lib.sh: unfilter GIT_PERF_*
2013-01-16 10:23 ` [PATCH v3] " Nguyễn Thái Ngọc Duy
@ 2013-01-16 18:54 ` Jonathan Nieder
0 siblings, 0 replies; 7+ messages in thread
From: Jonathan Nieder @ 2013-01-16 18:54 UTC (permalink / raw)
To: Nguyễn Thái Ngọc Duy; +Cc: git, Junio C Hamano, Thomas Rast
Nguyễn Thái Ngọc Duy wrote:
> These variables are user parameters to control how to run the perf
> tests. Allow users to do so.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
FWIW, of the three versions proposed, this one makes the most sense to
me. Looks good.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-01-16 18:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-15 12:53 [PATCH] test-lib.sh: unfilter GIT_PERF_* Nguyễn Thái Ngọc Duy
2013-01-15 13:43 ` Thomas Rast
2013-01-15 13:47 ` Duy Nguyen
2013-01-15 13:50 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2013-01-15 19:31 ` Junio C Hamano
2013-01-16 10:23 ` [PATCH v3] " Nguyễn Thái Ngọc Duy
2013-01-16 18:54 ` Jonathan Nieder
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).