From: Duy Nguyen <pclouds@gmail.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] test-lib.sh: unfilter GIT_PERF_*
Date: Tue, 15 Jan 2013 20:47:52 +0700 [thread overview]
Message-ID: <CACsJy8BaPfiHL86uh8QOKXzBXb3eKiRnN1MV0e8WegsFzodWHQ@mail.gmail.com> (raw)
In-Reply-To: <87ehhmr28g.fsf@pctrast.inf.ethz.ch>
On Tue, Jan 15, 2013 at 8:43 PM, Thomas Rast <trast@student.ethz.ch> wrote:
> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>> These variables are user parameters to control how to run the perf
>> tests. Allow users to do so.
> [...]
>> @@ -86,6 +86,9 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e '
>> PROVE
>> VALGRIND
>> PERF_AGGREGATING_LATER
>> + PERF_LARGE_REPO
>> + PERF_REPEAT_COUNT
>> + PERF_REPO
>> ));
>
> Wouldn't it be more futureproof to put simply PERF as an entry, and rely
> on the leading-match logic
>
>> my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);
>
> to allow all GIT_PERF variables?
Yeah.
> Other than that, Ack. I never noticed because I set mine through
> config.mak, which goes to GIT-BUILD-OPTIONS. Those options are not
> exported, which means perl does not pick them up. (That just took me
> far too long to realize.)
By the way is there an option to skip the first few runs (too lazy to
check out the source code, apparently)? I tried linux-2.6 as the large
repo and I think the first (cold cache) run ruins the numbers.
--
Duy
next prev parent reply other threads:[~2013-01-15 13:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 12:53 [PATCH] test-lib.sh: unfilter GIT_PERF_* Nguyễn Thái Ngọc Duy
2013-01-15 13:43 ` Thomas Rast
2013-01-15 13:47 ` Duy Nguyen [this message]
2013-01-15 13:50 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2013-01-15 19:31 ` Junio C Hamano
2013-01-16 10:23 ` [PATCH v3] " Nguyễn Thái Ngọc Duy
2013-01-16 18:54 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8BaPfiHL86uh8QOKXzBXb3eKiRnN1MV0e8WegsFzodWHQ@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).