From: Philip Oakley <philipoakley@iee.org>
To: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Cc: "Duy Nguyen" <pclouds@gmail.com>,
"Christian Couder" <christian.couder@gmail.com>,
git <git@vger.kernel.org>,
"Thomas Gummerer" <t.gummerer@gmail.com>,
"Оля Тележная" <olyatelezhnaya@gmail.com>,
"Elijah Newren" <newren@gmail.com>,
"Tanushree Tumane" <tanushreetumane@gmail.com>,
"Torsten Bögershausen" <tboegi@web.de>
Subject: Re: [GSoC][RFC] Proposal: Make pack access code thread-safe
Date: Mon, 8 Apr 2019 20:19:58 +0100 [thread overview]
Message-ID: <1348d823-9729-a5eb-2104-df7c4a41911d@iee.org> (raw)
In-Reply-To: <CAHd-oW5PFmj4u2YB-1TcHWNxkokfCEsUq_zB=Rx2Vmdk5Z9eMw@mail.gmail.com>
Hi Matheus
On 08/04/2019 18:04, Matheus Tavares Bernardino wrote:
>> Another "32-bit problem" should also be expressly considered during the
>> GSoC work because of the MS Windows definition of uInt / long to be only
>> 32 bits, leading to much of the Git code failing on the Git for Windows
>> port and on the Git LFS (for Windows) for packs and files greater than
>> 4Gb.https://github.com/git-for-windows/git/issues/1063
> Thanks for pointing it out. I didn't get it, thought, if your
> suggestion was to also propose tackling this issue in this GSoC
> project. Was it that? I read the link but it seems to be a kind of
> unrelated problem from what I'm planing to do with the pack access
> code (which is tread-safety). I may have understood this wrongly,
> though. Please, let me know if that's the case :)
>
The main point was to avoid accidental regressions by re-introducing
simple 'longs' where memsized types were more appropriate.
Torsten has already done a lot of work at
https://github.com/tboegi/git/tree/tb.190402_1552_convert_size_t_only_git_master_181124_mk_size_t
HTH
Philip
(I'm off line for a few days)
next prev parent reply other threads:[~2019-04-08 19:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-07 20:48 [GSoC][RFC] Proposal: Make pack access code thread-safe Matheus Tavares Bernardino
2019-04-07 22:52 ` Christian Couder
2019-04-08 1:23 ` Duy Nguyen
2019-04-08 3:32 ` Duy Nguyen
2019-04-08 6:58 ` Christian Couder
2019-04-08 16:03 ` Matheus Tavares Bernardino
2019-04-08 15:58 ` Matheus Tavares Bernardino
2019-04-08 9:26 ` Philip Oakley
2019-04-08 17:04 ` Matheus Tavares Bernardino
2019-04-08 19:19 ` Philip Oakley [this message]
2019-04-08 19:36 ` Matheus Tavares Bernardino
2019-04-09 5:54 ` Torsten Bögershausen
2019-04-08 16:42 ` Matheus Tavares Bernardino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348d823-9729-a5eb-2104-df7c4a41911d@iee.org \
--to=philipoakley@iee.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=matheus.bernardino@usp.br \
--cc=newren@gmail.com \
--cc=olyatelezhnaya@gmail.com \
--cc=pclouds@gmail.com \
--cc=t.gummerer@gmail.com \
--cc=tanushreetumane@gmail.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).