mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Philip Oakley <>
To: Duy Nguyen <>,
	Christian Couder <>
Cc: "Matheus Tavares Bernardino" <>,
	git <>,
	"Thomas Gummerer" <>,
	"Оля Тележная" <>,
	"Elijah Newren" <>,
	"Tanushree Tumane" <>
Subject: Re: [GSoC][RFC] Proposal: Make pack access code thread-safe
Date: Mon, 8 Apr 2019 10:26:55 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 08/04/2019 02:23, Duy Nguyen wrote:
> On Mon, Apr 8, 2019 at 5:52 AM Christian Couder
> <> wrote:
>>> Git has a very optimized mechanism to compactly store
>>> objects (blobs, trees, commits, etc.) in packfiles[2]. These files are
>>> created by[3]:
>>> 1. listing objects;
>>> 2. sorting the list with some good heuristics;
>>> 3. traversing the list with a sliding window to find similar objects in
>>> the window, in order to do delta decomposing;
>>> 4. compress the objects with zlib and write them to the packfile.
>>> What we are calling pack access code in this document, is the set of
>>> functions responsible for retrieving the objects stored at the
>>> packfiles. This process consists, roughly speaking, in three parts:
>>> 1. Locate and read the blob from packfile, using the index file;
>>> 2. If the blob is a delta, locate and read the base object to apply the
>>> delta on top of it;
>>> 3. Once the full content is read, decompress it (using zlib inflate).
>>> Note: There is a delta cache for the second step so that if another
>>> delta depends on the same base object, it is already in memory. This
>>> cache is global; also, the sliding windows, are global per packfile.
>> Yeah, but the sliding windows are used only when creating pack files,
>> not when reading them, right?
> These windows are actually for reading. We used to just mmap the whole
> pack file in the early days but that was impossible for 4+ GB packs on
> 32-bit platforms, which was one of the reasons, I think, that sliding
> windows were added, to map just the parts we want to read.

Another "32-bit problem" should also be expressly considered during the 
GSoC work because of the MS Windows definition of uInt / long to be only 
32 bits, leading to much of the Git code failing on the Git for Windows 
port and on the Git LFS (for Windows) for packs and files greater than 

Mainly it is just substitution of size_t for long, but there can be 
unexpected coercions when mixed data types get coerced down to a local 
32-bit long. This is made worse by it being implementation defined, so 
one needs to be explicit about some casts up to pointer/memsized types.
>>> # Points to work on
>>> * Investigate pack access call chains and look for non-thread-safe
>>> operations on then.
>>> * Protect packfile.c read-and-write global variables, such as
>>> pack_open_windows, pack_open_fds and etc., using mutexes.
>> Do you want to work on making both packfile reading and packfile
>> writing thread safe? Or just packfile reading?
> Packfile writing is probably already or pretty close to thread-safe
> (at least the main writing code path in git-pack-objects; the
> streaming blobs to a pack, i'm not so sure).

  parent reply	other threads:[~2019-04-08  9:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-07 20:48 [GSoC][RFC] Proposal: Make pack access code thread-safe Matheus Tavares Bernardino
2019-04-07 22:52 ` Christian Couder
2019-04-08  1:23   ` Duy Nguyen
2019-04-08  3:32     ` Duy Nguyen
2019-04-08  6:58       ` Christian Couder
2019-04-08 16:03         ` Matheus Tavares Bernardino
2019-04-08 15:58       ` Matheus Tavares Bernardino
2019-04-08  9:26     ` Philip Oakley [this message]
2019-04-08 17:04       ` Matheus Tavares Bernardino
2019-04-08 19:19         ` Philip Oakley
2019-04-08 19:36           ` Matheus Tavares Bernardino
2019-04-09  5:54             ` Torsten Bögershausen
2019-04-08 16:42   ` Matheus Tavares Bernardino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).