From: DJ Delorie <dj@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: bug-gnulib@gnu.org
Subject: Re: [patch] glob: resolve DT_UNKNOWN via is_dir
Date: Wed, 17 Nov 2021 17:38:11 -0500 [thread overview]
Message-ID: <xn5ysq2yss.fsf@greed.delorie.com> (raw)
In-Reply-To: <87y25m1lcl.fsf@oldenburg.str.redhat.com>
Florian Weimer <fweimer@redhat.com> writes:
> I thought the bug is that it's not actually a hint? That DT_UNKNOWN
> here leads to incorrect results in glob?
All the DT_* are hints, according to the man pages, which say that
DT_UNKNOWN must be handled by the caller. So I guess it depends on
whether the original developers knew this and weren't worried about
accuracy, or if there were no filesystems that ever returned DT_UNKNOWN
for regular files, so it was decided to always include "I don't know"'s
as a "future proofing" option.
Doesn't matter to me either way, of course.
next prev parent reply other threads:[~2021-11-17 22:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 3:45 [patch] glob: resolve DT_UNKNOWN via is_dir DJ Delorie
2021-11-17 11:12 ` Florian Weimer
2021-11-17 21:59 ` DJ Delorie
2021-11-17 22:14 ` Florian Weimer
2021-11-17 22:38 ` DJ Delorie [this message]
2022-03-11 21:43 ` [patch v2] " DJ Delorie
2022-03-12 0:37 ` Paul Eggert
2022-03-23 4:34 ` DJ Delorie
2022-03-23 17:35 ` Paul Eggert
2022-03-25 19:18 ` DJ Delorie
2022-05-14 20:34 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xn5ysq2yss.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=bug-gnulib@gnu.org \
--cc=fweimer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).