bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org, Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: [patch v2] glob: resolve DT_UNKNOWN via is_dir
Date: Sat, 14 May 2022 22:34:51 +0200	[thread overview]
Message-ID: <8791298.gtipl9YmvM@omega> (raw)
In-Reply-To: <10114b5a-e146-e326-150d-f9973e36c956@cs.ucla.edu>

Paul Eggert wrote on 2022-03-23:
> The 3rd patch tests for glibc bug 25659 ...

This patch produces a warning

../../gltests/test-glob.c: In function 'main':
../../gltests/test-glob.c:77:17: warning: implicit declaration of function 'creat' [-Wimplicit-function-declaration]
   77 |       && close (creat (BASE "globfile", 0666)) == 0)
      |                 ^~~~~

Fixed as follows.


2022-05-14  Bruno Haible  <bruno@clisp.org>

	glob tests: Fix a warning (regression from 2022-03-23).
	* tests/test-glob.c: Include <fcntl.h>.
	* modules/glob-tests (Depends-on): Add fcntl-h.

diff --git a/modules/glob-tests b/modules/glob-tests
index ec519cf38d..afce2dbca0 100644
--- a/modules/glob-tests
+++ b/modules/glob-tests
@@ -4,6 +4,7 @@ tests/signature.h
 tests/macros.h
 
 Depends-on:
+fcntl-h
 symlink
 
 configure.ac:
diff --git a/tests/test-glob.c b/tests/test-glob.c
index 568acf14b7..61c7ca4583 100644
--- a/tests/test-glob.c
+++ b/tests/test-glob.c
@@ -26,6 +26,7 @@ SIGNATURE_CHECK (glob, int, (char const *, int, int (*) (char const *, int),
 SIGNATURE_CHECK (globfree, void, (glob_t *));
 
 #include <errno.h>
+#include <fcntl.h>
 #include <string.h>
 #include <unistd.h>
 





      parent reply	other threads:[~2022-05-14 20:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17  3:45 [patch] glob: resolve DT_UNKNOWN via is_dir DJ Delorie
2021-11-17 11:12 ` Florian Weimer
2021-11-17 21:59   ` DJ Delorie
2021-11-17 22:14     ` Florian Weimer
2021-11-17 22:38       ` DJ Delorie
2022-03-11 21:43 ` [patch v2] " DJ Delorie
2022-03-12  0:37   ` Paul Eggert
2022-03-23  4:34     ` DJ Delorie
2022-03-23 17:35       ` Paul Eggert
2022-03-25 19:18         ` DJ Delorie
2022-05-14 20:34         ` Bruno Haible [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8791298.gtipl9YmvM@omega \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).