From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 338801F4D7 for ; Sat, 14 May 2022 20:35:06 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=clisp.org header.i=@clisp.org header.b="S1x50jTn"; dkim-atps=neutral Received: from localhost ([::1]:48874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npyTg-0005qr-Sy for normalperson@yhbt.net; Sat, 14 May 2022 16:35:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npyTd-0005pu-6n for bug-gnulib@gnu.org; Sat, 14 May 2022 16:35:01 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.23]:34969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npyTb-0003Mj-5Z for bug-gnulib@gnu.org; Sat, 14 May 2022 16:35:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1652560492; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:To:From:Cc:Date:From: Subject:Sender; bh=OYo44C3cDfEQJcvFHS14FJRwegHBayMUD6zHaS6e6tA=; b=S1x50jTnHJ0SigzqH/GPolbx5xBdUp2WxF+6YPolJCPakyw1xuN2qIK2CnbFt2xHWD l+VQvO0m78s9nNJxs/fPfPHlTrsunj+2YZp0aeez6dj8p6KSqMB3p3cgJtR/iiSMpYxp HW1aukKntUBCafl1Mh03ozAka7TKSQ3wcoaCQ6q37/p4Nx4o7/V5hbvxUirS3tbI4GDA +gwCRCC5yi2xiR0G3dREGVyGlMsuTPiLNFRrObFQJ3IjGXKrR4w2HgBC1S1nEQ42Pq/w jxK2mY9xFRNaq+Slc7Pyc+SM1eaOrhU8AVVqqCXYBySN5DBDInqMHJEfxge+464LtMWV Tusg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zm6Ln9gbQraz1AFcrnrMIkNRDkQsLfc6WouFA==" X-RZG-CLASS-ID: mo00 Received: from omega.localnet by smtp.strato.de (RZmta 47.45.0 AUTH) with ESMTPSA id k059a7y4EKYpBg2 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Sat, 14 May 2022 22:34:51 +0200 (CEST) From: Bruno Haible To: bug-gnulib@gnu.org, Paul Eggert Subject: Re: [patch v2] glob: resolve DT_UNKNOWN via is_dir Date: Sat, 14 May 2022 22:34:51 +0200 Message-ID: <8791298.gtipl9YmvM@omega> In-Reply-To: <10114b5a-e146-e326-150d-f9973e36c956@cs.ucla.edu> References: <10114b5a-e146-e326-150d-f9973e36c956@cs.ucla.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=85.215.255.23; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Paul Eggert wrote on 2022-03-23: > The 3rd patch tests for glibc bug 25659 ... This patch produces a warning ../../gltests/test-glob.c: In function 'main': ../../gltests/test-glob.c:77:17: warning: implicit declaration of function 'creat' [-Wimplicit-function-declaration] 77 | && close (creat (BASE "globfile", 0666)) == 0) | ^~~~~ Fixed as follows. 2022-05-14 Bruno Haible glob tests: Fix a warning (regression from 2022-03-23). * tests/test-glob.c: Include . * modules/glob-tests (Depends-on): Add fcntl-h. diff --git a/modules/glob-tests b/modules/glob-tests index ec519cf38d..afce2dbca0 100644 --- a/modules/glob-tests +++ b/modules/glob-tests @@ -4,6 +4,7 @@ tests/signature.h tests/macros.h Depends-on: +fcntl-h symlink configure.ac: diff --git a/tests/test-glob.c b/tests/test-glob.c index 568acf14b7..61c7ca4583 100644 --- a/tests/test-glob.c +++ b/tests/test-glob.c @@ -26,6 +26,7 @@ SIGNATURE_CHECK (glob, int, (char const *, int, int (*) (char const *, int), SIGNATURE_CHECK (globfree, void, (glob_t *)); #include +#include #include #include