From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 48BB41F9F4 for ; Wed, 17 Nov 2021 22:38:24 +0000 (UTC) Received: from localhost ([::1]:47308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnTZP-0003lZ-3x for normalperson@yhbt.net; Wed, 17 Nov 2021 17:38:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnTZM-0003lO-DE for bug-gnulib@gnu.org; Wed, 17 Nov 2021 17:38:20 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33599) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnTZJ-0005n2-BO for bug-gnulib@gnu.org; Wed, 17 Nov 2021 17:38:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637188695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=qJTaNj3opj31tKNfqXWU9IR9mBf1obdZ5jQi/QpgrGI=; b=iOavHZUNy6EaZktUAuLe4XYUKanvVHqy/IIW5RYF0UhHLHWUYDeBWaR55RUIDaVC8F5KwZ pS+vK4hh20mbl1YL99S9XE8UgPqNXYvZIpmA/pz1A4Wn26RFMHdO+Z/WAP6qtlz24W4zOz /ou5ihV5GNe5/pj9o+7KwFe9Lm1WaQo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-599-0Tp88XnIM_Cz2fLpPtVOQA-1; Wed, 17 Nov 2021 17:38:14 -0500 X-MC-Unique: 0Tp88XnIM_Cz2fLpPtVOQA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6429E804140 for ; Wed, 17 Nov 2021 22:38:13 +0000 (UTC) Received: from greed.delorie.com (ovpn-112-96.phx2.redhat.com [10.3.112.96]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F22BA60BF1; Wed, 17 Nov 2021 22:38:12 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.15.2/8.15.2) with ESMTP id 1AHMcBcK2945762; Wed, 17 Nov 2021 17:38:11 -0500 From: DJ Delorie To: Florian Weimer Subject: Re: [patch] glob: resolve DT_UNKNOWN via is_dir In-Reply-To: <87y25m1lcl.fsf@oldenburg.str.redhat.com> Date: Wed, 17 Nov 2021 17:38:11 -0500 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dj@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=dj@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.701, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Florian Weimer writes: > I thought the bug is that it's not actually a hint? That DT_UNKNOWN > here leads to incorrect results in glob? All the DT_* are hints, according to the man pages, which say that DT_UNKNOWN must be handled by the caller. So I guess it depends on whether the original developers knew this and weren't worried about accuracy, or if there were no filesystems that ever returned DT_UNKNOWN for regular files, so it was decided to always include "I don't know"'s as a "future proofing" option. Doesn't matter to me either way, of course.