From: Paul Eggert <eggert@cs.ucla.edu>
To: Bruno Haible <bruno@clisp.org>,
bug-gnulib@gnu.org,
Ondrej Valousek <ondrej.valousek.xm@renesas.com>
Subject: Re: [PATCH] Use xattr (Linux) in qcopy-acl.c
Date: Wed, 4 Jan 2023 11:29:53 -0800 [thread overview]
Message-ID: <e46d9ca3-600d-aa46-809f-89e3b9b9879b@cs.ucla.edu> (raw)
In-Reply-To: <10191473.L8ug28u51p@nimes>
On 2023-01-04 06:46, Bruno Haible wrote:
> To me, it looks good. Paul's opinion?
I see a problem in linking. With this change, programs using the
qcopy-acl module will link to both $(LIB_ACL) and $(LIB_XATTR), even
though they do not need to link with $(LIB_ACL). Perhaps you can fix
this by fixing the Link sections of the relevant modules to use
$(LIB_HAS_ACL) instead of $(LIB_ACL). That is, for each module where you
added $(LIB_XATTR), replace its $(LIB_ACL) with $(LIB_HAS_ACL) if the
only reason it needed $(LIB_ACL) was to copy attributes.
Also, come to think of it, is there a security issue between the
chmod_or_fchmod call, and the attr_copy_fd call? That is, could the file
temporarily be set to too-generous permissions, between the two calls? A
comment explaining this issue would help.
next prev parent reply other threads:[~2023-01-04 19:30 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 14:34 [PATCH] Use xattr (Linux) in qcopy-acl.c Ondrej Valousek
2023-01-04 14:46 ` Bruno Haible
2023-01-04 19:29 ` Paul Eggert [this message]
2023-01-04 20:54 ` Ondrej Valousek
2023-01-05 1:19 ` Paul Eggert
2023-01-13 9:15 ` ACL complexity Bruno Haible
2023-01-13 10:03 ` Ondrej Valousek
2023-01-13 11:05 ` Bruno Haible
2023-01-13 11:22 ` Ondrej Valousek
2023-01-05 9:00 ` [PATCH] Use xattr (Linux) in qcopy-acl.c Bruno Haible
2023-01-05 9:05 ` Ondrej Valousek
2023-01-05 10:32 ` Bruno Haible
2023-01-05 19:06 ` Paul Eggert
2023-01-11 9:11 ` Ondrej Valousek
2023-01-12 20:42 ` Bruno Haible
2023-01-13 7:51 ` Bruno Haible
2023-01-13 8:09 ` Bruno Haible
2023-01-13 8:32 ` Ondrej Valousek
2023-01-13 8:46 ` Bruno Haible
2023-01-14 1:52 ` Paul Eggert
2023-01-14 7:26 ` Ondrej Valousek
2023-01-14 7:55 ` Bruno Haible
2023-01-14 8:02 ` Ondrej Valousek
2023-01-13 8:33 ` Bruno Haible
2023-01-13 8:50 ` Bruno Haible
2023-01-30 10:18 ` Bruno Haible
2023-01-05 8:56 ` Bruno Haible
[not found] ` <TYXPR01MB18544D0A5C213BF0204BF0D4D9FD9@TYXPR01MB1854.jpnprd01.prod.outlook.com>
[not found] ` <c1ddff8c-2734-bfa1-11a3-3279ae9e92cb@cs.ucla.edu>
2023-01-12 20:58 ` Bruno Haible
2023-01-12 22:53 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e46d9ca3-600d-aa46-809f-89e3b9b9879b@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=ondrej.valousek.xm@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).