bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org, Ondrej Valousek <ondrej.valousek.xm@renesas.com>
Subject: Re: [PATCH] Use xattr (Linux) in qcopy-acl.c
Date: Fri, 13 Jan 2023 09:50:10 +0100	[thread overview]
Message-ID: <5709171.UesdLuknzO@nimes> (raw)
In-Reply-To: <7698295.mr9Zh2SJbS@nimes>

I wrote:
> 	* modules/qcopy-acl (Depends-on): Add condition.
> 	(configure.ac): Set QCOPY_ACL_LIB.
> 	(Link): Add $(QCOPY_ACL_LIB). Remove $(LIB_ACL).

Oops, this has a mistake. The variable LIB_ACL needs to be initialized
before the code uses its value; otherwise $LIB_ACL will come out as empty.
The way to order the initialization is to use AC_REQUIRE of the macro
which defines LIB_ACL. Then, since invocation and AC_REQUIRE of a macro
defined through AC_DEFUN triggers an autoconf warning, one needs AC_DEFUN_ONCE
instead.


2023-01-13  Bruno Haible  <bruno@clisp.org>

	qcopy-acl: Make last patch more robust.
	* m4/acl.m4 (gl_FUNC_ACL): Define through AC_DEFUN_ONCE.
	* modules/qcopy-acl (configure.ac): Require gl_FUNC_ACL.

diff --git a/m4/acl.m4 b/m4/acl.m4
index e612f1ae34..dc9853a156 100644
--- a/m4/acl.m4
+++ b/m4/acl.m4
@@ -1,5 +1,5 @@
 # acl.m4 - check for access control list (ACL) primitives
-# serial 26
+# serial 27
 
 # Copyright (C) 2002, 2004-2023 Free Software Foundation, Inc.
 # This file is free software; the Free Software Foundation
@@ -17,7 +17,7 @@ AC_DEFUN([gl_FUNC_ACL_ARG],
 ])
 
 
-AC_DEFUN([gl_FUNC_ACL],
+AC_DEFUN_ONCE([gl_FUNC_ACL],
 [
   AC_REQUIRE([gl_FUNC_ACL_ARG])
   AC_CHECK_FUNCS_ONCE([fchmod])
diff --git a/modules/qcopy-acl b/modules/qcopy-acl
index 8dd147927d..b89d8ecab6 100644
--- a/modules/qcopy-acl
+++ b/modules/qcopy-acl
@@ -10,6 +10,7 @@ acl-permissions [test "$use_xattr" != yes]
 
 configure.ac:
 gl_FUNC_XATTR
+AC_REQUIRE([gl_FUNC_ACL])
 if test "$use_xattr" = yes; then
   QCOPY_ACL_LIB="$LIB_XATTR"
 else





  reply	other threads:[~2023-01-13  8:50 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04 14:34 [PATCH] Use xattr (Linux) in qcopy-acl.c Ondrej Valousek
2023-01-04 14:46 ` Bruno Haible
2023-01-04 19:29   ` Paul Eggert
2023-01-04 20:54     ` Ondrej Valousek
2023-01-05  1:19       ` Paul Eggert
2023-01-13  9:15         ` ACL complexity Bruno Haible
2023-01-13 10:03           ` Ondrej Valousek
2023-01-13 11:05             ` Bruno Haible
2023-01-13 11:22               ` Ondrej Valousek
2023-01-05  9:00       ` [PATCH] Use xattr (Linux) in qcopy-acl.c Bruno Haible
2023-01-05  9:05         ` Ondrej Valousek
2023-01-05 10:32           ` Bruno Haible
2023-01-05 19:06             ` Paul Eggert
2023-01-11  9:11               ` Ondrej Valousek
2023-01-12 20:42                 ` Bruno Haible
2023-01-13  7:51                   ` Bruno Haible
2023-01-13  8:09                     ` Bruno Haible
2023-01-13  8:32                       ` Ondrej Valousek
2023-01-13  8:46                         ` Bruno Haible
2023-01-14  1:52                           ` Paul Eggert
2023-01-14  7:26                             ` Ondrej Valousek
2023-01-14  7:55                               ` Bruno Haible
2023-01-14  8:02                                 ` Ondrej Valousek
2023-01-13  8:33               ` Bruno Haible
2023-01-13  8:50                 ` Bruno Haible [this message]
2023-01-30 10:18                 ` Bruno Haible
2023-01-05  8:56     ` Bruno Haible
     [not found] ` <TYXPR01MB18544D0A5C213BF0204BF0D4D9FD9@TYXPR01MB1854.jpnprd01.prod.outlook.com>
     [not found]   ` <c1ddff8c-2734-bfa1-11a3-3279ae9e92cb@cs.ucla.edu>
2023-01-12 20:58     ` Bruno Haible
2023-01-12 22:53       ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5709171.UesdLuknzO@nimes \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=ondrej.valousek.xm@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).