From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-5.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1E1121F47C for ; Wed, 4 Jan 2023 19:30:14 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=cs.ucla.edu header.i=@cs.ucla.edu header.a=rsa-sha256 header.s=78364E5A-2AF3-11ED-87FA-8298ECA2D365 header.b=UwsWrq8e; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pD9Sd-0003Z3-Mi; Wed, 04 Jan 2023 14:30:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD9Sb-0003YV-6q for bug-gnulib@gnu.org; Wed, 04 Jan 2023 14:30:01 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD9SZ-0008Ir-EU for bug-gnulib@gnu.org; Wed, 04 Jan 2023 14:30:00 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7540116005C; Wed, 4 Jan 2023 11:29:54 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id wspLUQEeAK19; Wed, 4 Jan 2023 11:29:53 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B74B5160064; Wed, 4 Jan 2023 11:29:53 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu B74B5160064 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1672860593; bh=AQUlGRC4ELyOVD1GEuWg+FFLid5VnF24unJM9sRjFPU=; h=Message-ID:Date:MIME-Version:To:From:Subject:Content-Type: Content-Transfer-Encoding; b=UwsWrq8ebq2wDFQjhJ++diWC5Vkp0nlmMF2sRyQT/yQwROOxEjcdrXRubvP8PmYIH 6YYGFzcJKvUDr5TfLAXmOzDHj23eJ7V5G99tMdX7Ytrk4DkQJi6brTCpMQu2mJwrQU prwT3cluT7gU89DxMM3zgG283bJ9OJN2LAZmLzyY= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id epQEaozJU46y; Wed, 4 Jan 2023 11:29:53 -0800 (PST) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 8CE4216005C; Wed, 4 Jan 2023 11:29:53 -0800 (PST) Message-ID: Date: Wed, 4 Jan 2023 11:29:53 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US To: Bruno Haible , bug-gnulib@gnu.org, Ondrej Valousek References: <20230104143425.1235741-1-ondrej.valousek.xm@renesas.com> <10191473.L8ug28u51p@nimes> From: Paul Eggert Organization: UCLA Computer Science Department Subject: Re: [PATCH] Use xattr (Linux) in qcopy-acl.c In-Reply-To: <10191473.L8ug28u51p@nimes> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -59 X-Spam_score: -6.0 X-Spam_bar: ------ X-Spam_report: (-6.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, NICE_REPLY_A=-1.708, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org On 2023-01-04 06:46, Bruno Haible wrote: > To me, it looks good. Paul's opinion? I see a problem in linking. With this change, programs using the qcopy-acl module will link to both $(LIB_ACL) and $(LIB_XATTR), even though they do not need to link with $(LIB_ACL). Perhaps you can fix this by fixing the Link sections of the relevant modules to use $(LIB_HAS_ACL) instead of $(LIB_ACL). That is, for each module where you added $(LIB_XATTR), replace its $(LIB_ACL) with $(LIB_HAS_ACL) if the only reason it needed $(LIB_ACL) was to copy attributes. Also, come to think of it, is there a security issue between the chmod_or_fchmod call, and the attr_copy_fd call? That is, could the file temporarily be set to too-generous permissions, between the two calls? A comment explaining this issue would help.