From: Paul Eggert <eggert@cs.ucla.edu>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: bug-gnulib@gnu.org,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
Vaseeharan Vinayagamoorthy <Vaseeharan.Vinayagamoorthy@arm.com>
Subject: Re: [PATCH 1/5] posix: Sync regex code with gnulib
Date: Wed, 20 Jan 2021 09:46:03 -0800 [thread overview]
Message-ID: <cec1b686-05de-6c14-a715-ef89cce3825b@cs.ucla.edu> (raw)
In-Reply-To: <10cb3123-40a4-931f-c658-99382367db6b@linaro.org>
On 1/20/21 3:27 AM, Adhemerval Zanella wrote:
>> #if defined __STDC_VERSION__ && 201710L < __STDC_VERSION__
>> # define __attribute_fallthrough__ [[__fallthrough__]]
>> #elif __GNUC_PREREQ (7, 0) || __glibc_has_attribute (__fallthrough__)
>> # define __attribute_fallthrough__ __attribute__ ((__fallthrough__))
>> #else
>> # define __attribute_fallthrough__ ((void) 0)
>> #endif
> Yes, for 2.34 I will send some patches to sync the remaining gnulib
> files and document from our part the shared files.
On thinking about it more (for 2.34), I find that I would prefer the
current Gnulib practice of using 'FALLTHROUGH;' to using
'__attribute_fallthrough__;' in code, and so suggest Gnulib's approach
of having an attribute.h file (purely for internal glibc use) that has
"#define FALLTHROUGH __attribute__ (__fallthrough__)' etc.
next prev parent reply other threads:[~2021-01-20 17:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 20:15 [PATCH 1/5] posix: Sync regex code with gnulib Adhemerval Zanella
2020-12-30 20:15 ` [PATCH 2/5] posix: Sync glob " Adhemerval Zanella
2020-12-31 21:47 ` Paul Eggert
2020-12-30 20:15 ` [PATCH 3/5] Sync intprops.h " Adhemerval Zanella
2020-12-31 21:47 ` Paul Eggert
2020-12-30 20:15 ` [PATCH 4/5] Sync flexmember.h " Adhemerval Zanella
2020-12-31 21:48 ` Paul Eggert
2020-12-30 20:15 ` [PATCH 5/5] posix: Sync fnmatch " Adhemerval Zanella
2020-12-31 21:54 ` Paul Eggert
2020-12-31 21:37 ` [PATCH 1/5] posix: Sync regex code " Paul Eggert
2021-01-19 14:16 ` Vaseeharan Vinayagamoorthy
2021-01-19 14:43 ` Adhemerval Zanella
2021-01-19 15:43 ` Bruno Haible
2021-01-20 2:55 ` Paul Eggert
2021-01-20 11:27 ` Adhemerval Zanella
2021-01-20 15:32 ` Vaseeharan Vinayagamoorthy
2021-01-20 16:05 ` Adhemerval Zanella
2021-01-20 17:46 ` Paul Eggert [this message]
2021-01-19 16:52 ` Florian Weimer
2021-01-19 17:11 ` Adhemerval Zanella
2021-01-19 17:16 ` Florian Weimer
2021-01-19 17:18 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cec1b686-05de-6c14-a715-ef89cce3825b@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=Vaseeharan.Vinayagamoorthy@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=bug-gnulib@gnu.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).