From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: "bug-gnulib@gnu.org" <bug-gnulib@gnu.org>,
Paul Eggert <eggert@cs.ucla.edu>,
Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>,
Vaseeharan Vinayagamoorthy <Vaseeharan.Vinayagamoorthy@arm.com>
Subject: Re: [PATCH 1/5] posix: Sync regex code with gnulib
Date: Tue, 19 Jan 2021 14:18:44 -0300 [thread overview]
Message-ID: <bdc04e4c-21cc-0533-4e32-498d8d2fe127@linaro.org> (raw)
In-Reply-To: <87y2go7spn.fsf@oldenburg.str.redhat.com>
On 19/01/2021 14:16, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> On 19/01/2021 13:52, Florian Weimer wrote:
>>> * Adhemerval Zanella via Libc-alpha:
>>>
>>>> Paul, this seemed to a common pattern scatter on multiple file in gnulib.
>>>> Wouldn't be better to consolidate it on cdefs.h?
>>>
>>> gnulib shouldn't be using cdefs.h on glibc systems, so I think a
>>> separate header would be needed.
>>
>> What is the problem of using cdefs.h for internal implementation?
>
> Isn't regex_internal.h sync'ed with gnulib?
Yes, and gnulib also has an internal cdefs (which we should sync btw).
prev parent reply other threads:[~2021-01-19 17:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 20:15 [PATCH 1/5] posix: Sync regex code with gnulib Adhemerval Zanella
2020-12-30 20:15 ` [PATCH 2/5] posix: Sync glob " Adhemerval Zanella
2020-12-31 21:47 ` Paul Eggert
2020-12-30 20:15 ` [PATCH 3/5] Sync intprops.h " Adhemerval Zanella
2020-12-31 21:47 ` Paul Eggert
2020-12-30 20:15 ` [PATCH 4/5] Sync flexmember.h " Adhemerval Zanella
2020-12-31 21:48 ` Paul Eggert
2020-12-30 20:15 ` [PATCH 5/5] posix: Sync fnmatch " Adhemerval Zanella
2020-12-31 21:54 ` Paul Eggert
2020-12-31 21:37 ` [PATCH 1/5] posix: Sync regex code " Paul Eggert
2021-01-19 14:16 ` Vaseeharan Vinayagamoorthy
2021-01-19 14:43 ` Adhemerval Zanella
2021-01-19 15:43 ` Bruno Haible
2021-01-20 2:55 ` Paul Eggert
2021-01-20 11:27 ` Adhemerval Zanella
2021-01-20 15:32 ` Vaseeharan Vinayagamoorthy
2021-01-20 16:05 ` Adhemerval Zanella
2021-01-20 17:46 ` Paul Eggert
2021-01-19 16:52 ` Florian Weimer
2021-01-19 17:11 ` Adhemerval Zanella
2021-01-19 17:16 ` Florian Weimer
2021-01-19 17:18 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdc04e4c-21cc-0533-4e32-498d8d2fe127@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=Vaseeharan.Vinayagamoorthy@arm.com \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).