test-striconveh fail to build without libiconv

test-striconveh fail to build without libiconv

[Tom G. Christensen]

Hello,

In 8c96eb80bd calls to iconv functions were added outside the HAVE_ICONV 
block.

test-striconveh.c will fail to build if iconv is unavailable:
test-striconveh.c: In function 'main':
test-striconveh.c:1113:7: error: 'cd_ascii_to_88591' undeclared (first 
use in this function)
    if (cd_ascii_to_88591 != (iconv_t)(-1))
        ^
test-striconveh.c:1113:7: note: each undeclared identifier is reported 
only once for each function it appears in
test-striconveh.c:1113:29: error: 'iconv_t' undeclared (first use in 
this function)
    if (cd_ascii_to_88591 != (iconv_t)(-1))
                              ^
test-striconveh.c:1114:5: warning: implicit declaration of function 
'iconv_close' [-Wimplicit-function-declaration]
      iconv_close (cd_ascii_to_88591);
      ^
test-striconveh.c:1115:16: error: 'cd_ascii_to_utf8' undeclared (first 
use in this function)
    iconv_close (cd_ascii_to_utf8);
                 ^
test-striconveh.c:1116:7: error: 'cd_utf7_to_utf8' undeclared (first use 
in this function)
    if (cd_utf7_to_utf8 != (iconv_t)(-1))
        ^
make[4]: *** [test-striconveh.o] Error 1


-tgc

Re: test-striconveh fail to build without libiconv

[Bruno Haible]

Hi Tom,

> In 8c96eb80bd calls to iconv functions were added outside the HAVE_ICONV 
> block.
> 
> test-striconveh.c will fail to build if iconv is unavailable:
> test-striconveh.c: In function 'main':
> test-striconveh.c:1113:7: error: 'cd_ascii_to_88591' undeclared (first 
> use in this function)
>     if (cd_ascii_to_88591 != (iconv_t)(-1))
>         ^

Thanks for the report. This patch should fix it.


2019-07-09  Bruno Haible  <bruno@clisp.org>

	striconveh test: Fix a compilation failure when iconv is not available.
	Reported by Tom G. Christensen <tgc@jupiterrise.com>.
	* tests/test-striconveh.c (main): Move iconv_close invocations inside
	HAVE_ICONV.

diff --git a/tests/test-striconveh.c b/tests/test-striconveh.c
index ed41884..c2fb8bb 100644
--- a/tests/test-striconveh.c
+++ b/tests/test-striconveh.c
@@ -1106,8 +1106,6 @@ main ()
       free (result);
     }
 
-#endif
-
   /* -------------------------------- Done. -------------------------------- */
 
   if (cd_ascii_to_88591 != (iconv_t)(-1))
@@ -1116,5 +1114,7 @@ main ()
   if (cd_utf7_to_utf8 != (iconv_t)(-1))
     iconv_close (cd_utf7_to_utf8);
 
+#endif
+
   return 0;
 }