From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4634F1F461 for ; Tue, 9 Jul 2019 06:50:36 +0000 (UTC) Received: from localhost ([::1]:47192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkjxR-0003TA-UC for normalperson@yhbt.net; Tue, 09 Jul 2019 02:50:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37171) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkjxF-0003OC-Bt for bug-gnulib@gnu.org; Tue, 09 Jul 2019 02:50:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkjxE-0008O4-Bb for bug-gnulib@gnu.org; Tue, 09 Jul 2019 02:50:21 -0400 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::12]:13604) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hkjxC-0008LW-CW for bug-gnulib@gnu.org; Tue, 09 Jul 2019 02:50:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1562655012; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=g8ngpViYe0+wPF/Ajnc2r3gXwdVUvAr8sQqDfMaDZTU=; b=he9AuTrFpyU47kZZZG8mQzUa7QKQM91gOTV7IJu8yzXgKhJa2t/NYAAm2L0oHdfAdT W4mfgsc85wXVq1KFCHWUHOL4lLXlI9p0xgXfrzMTIu4SB5SU0ayOI/B/742XcNEKbvmP UpXDmmFOViYksGE+p7xhoYh1vybA0Z3elVrGs00pGb27+VQ8NLwLnSbMiYULbU/QZKol xOTfXX77cGF4S0KyGbCcYSe38UpO6Hy/Gz3mhKBawUtCHV4ehqNmC96HXNqFU4/lAq6A j8YLEhKovyABgRjLMrok/bkFbtC7A8Cw+JFUnHY/Q7pEF+yuyB/Rd2pH0CY0dWuo8pP+ NqrA== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOGaf0zJZW" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 44.24 DYNA|AUTH) with ESMTPSA id v018bcv696o9kT1 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Tue, 9 Jul 2019 08:50:09 +0200 (CEST) From: Bruno Haible To: bug-gnulib@gnu.org Subject: Re: test-striconveh fail to build without libiconv Date: Tue, 09 Jul 2019 08:50:08 +0200 Message-ID: <13855102.WtOpISMboX@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-151-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a01:238:20a:202:5300::12 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Hi Tom, > In 8c96eb80bd calls to iconv functions were added outside the HAVE_ICONV > block. > > test-striconveh.c will fail to build if iconv is unavailable: > test-striconveh.c: In function 'main': > test-striconveh.c:1113:7: error: 'cd_ascii_to_88591' undeclared (first > use in this function) > if (cd_ascii_to_88591 != (iconv_t)(-1)) > ^ Thanks for the report. This patch should fix it. 2019-07-09 Bruno Haible striconveh test: Fix a compilation failure when iconv is not available. Reported by Tom G. Christensen . * tests/test-striconveh.c (main): Move iconv_close invocations inside HAVE_ICONV. diff --git a/tests/test-striconveh.c b/tests/test-striconveh.c index ed41884..c2fb8bb 100644 --- a/tests/test-striconveh.c +++ b/tests/test-striconveh.c @@ -1106,8 +1106,6 @@ main () free (result); } -#endif - /* -------------------------------- Done. -------------------------------- */ if (cd_ascii_to_88591 != (iconv_t)(-1)) @@ -1116,5 +1114,7 @@ main () if (cd_utf7_to_utf8 != (iconv_t)(-1)) iconv_close (cd_utf7_to_utf8); +#endif + return 0; }