From: Michael Hudson-Doyle <michael.hudson@canonical.com>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: Bruno Haible <bruno@clisp.org>, bug-gnulib@gnu.org
Subject: Re: test-rwlock1 failing on latest Fedora Rawhide
Date: Thu, 24 Jan 2019 10:17:36 +1300 [thread overview]
Message-ID: <CAJ8wqtdQmoGJ+r7bhiba6aGYmt9O+-xWxU537aPvSK3vHm5JOQ@mail.gmail.com> (raw)
In-Reply-To: <20190123210321.GA22317@altlinux.org>
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
On Thu, 24 Jan 2019 at 10:03, Dmitry V. Levin <ldv@altlinux.org> wrote:
> Hi,
>
> On Wed, Jan 23, 2019 at 08:45:06PM +0000, Richard W.M. Jones wrote:
> > On Wed, Jan 23, 2019 at 09:01:19PM +0100, Bruno Haible wrote:
> [...]
> > I checked the history of the Fedora package which adds these flags, and
> > it seems like --as-needed was added for:
> >
> > https://fedoraproject.org/wiki/Changes/RemoveExcessiveLinking
> >
> > Removing -Wl,--as-needed fixes the problem. However I'm still unclear
> > about this. Is Fedora wrong? Is hivex using gnulib wrongly? Is
> > gnulib wrong?
>
> We also build everything with --as-needed by default, but
> gnulib does the right thing nowadays by using
> -Wl,--push-state -Wl,--no-as-needed -lpthread -Wl,--pop-state
> instead of plain -lpthread.
>
libtool can "helpfully" reorder those flags so they don't do anything
though.
Cheers,
mwh
[-- Attachment #2: Type: text/html, Size: 1456 bytes --]
prev parent reply other threads:[~2019-01-23 21:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 19:37 test-rwlock1 failing on latest Fedora Rawhide Richard W.M. Jones
2019-01-23 20:01 ` Bruno Haible
2019-01-23 20:45 ` Richard W.M. Jones
2019-01-23 21:03 ` Dmitry V. Levin
2019-01-23 21:14 ` Richard W.M. Jones
2019-01-23 22:09 ` Dmitry V. Levin
2019-01-23 22:24 ` Richard W.M. Jones
2019-01-23 22:38 ` Dmitry V. Levin
2019-01-24 3:18 ` Bruno Haible
2019-01-24 3:31 ` Bruno Haible
2019-01-24 3:49 ` Bruno Haible
2019-01-24 8:57 ` Richard W.M. Jones
2019-01-24 8:50 ` Richard W.M. Jones
2019-01-23 21:17 ` Michael Hudson-Doyle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ8wqtdQmoGJ+r7bhiba6aGYmt9O+-xWxU537aPvSK3vHm5JOQ@mail.gmail.com \
--to=michael.hudson@canonical.com \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=ldv@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).