From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_PASS, URIBL_SBL,URIBL_SBL_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7502B1F453 for ; Wed, 23 Jan 2019 21:27:44 +0000 (UTC) Received: from localhost ([127.0.0.1]:42069 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmQ3i-0001Mr-3B for normalperson@yhbt.net; Wed, 23 Jan 2019 16:27:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmPxw-0004sk-5T for bug-gnulib@gnu.org; Wed, 23 Jan 2019 16:21:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmPuC-0007vK-6z for bug-gnulib@gnu.org; Wed, 23 Jan 2019 16:17:53 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:43033) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gmPuC-0007uc-1b for bug-gnulib@gnu.org; Wed, 23 Jan 2019 16:17:52 -0500 Received: from mail-wr1-f72.google.com ([209.85.221.72]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1gmPu9-0004M1-0b for bug-gnulib@gnu.org; Wed, 23 Jan 2019 21:17:49 +0000 Received: by mail-wr1-f72.google.com with SMTP id z16so1585159wrt.5 for ; Wed, 23 Jan 2019 13:17:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H3pbR1rMdTV1jtSMaUJhVbAw989xfYAgpaC1t6yzBmY=; b=dTST9rOS+qHqp+dSTA196pvQKnRqIZLnSr2KHe8yZz2sdpaKIVT98S/LcR8XaPQT/d y+fVAs9kjvSRzQFgkTm1uxVKNb0CXn60/46LpwRMkk179xubRtyK7r0egxplUIMsU9zL OBLgVqrDlsd+bcENX791M8pvpMVP4c9o0hhUvzQFvyp60zWfojNvcpEE1+xXlw8u6Hi7 yCyQWoZItp0q6gSQ/lUYfEL35cb0QGY7pEGAdXtPNiI3Le8dV1/g8D7g3ZoOOek0bJ5p j5FPmz61mRzdpwTXvxSM5CjqazyWKKqTzWN4CxvP2bMdCUt+kezbA6n3Zlufmb+8RODT Ytsg== X-Gm-Message-State: AJcUukf1Em+psi/2Lny3T6jXmtFES1y1VBj+xk6K+6fwgmswYrG+h2KY gWEOjqH4q1vrfA7pzCa9A0jTZ35tsNw5L9IxCeFSgMu8WqkF+BoamiJ6gEhe5ai6r9gLHgOWPRr bAupZOhEqgWMwTJL+J/BpGgi9tVxPZImmVV2ntz6n0NVH X-Received: by 2002:a7b:c853:: with SMTP id c19mr3997043wml.61.1548278268638; Wed, 23 Jan 2019 13:17:48 -0800 (PST) X-Google-Smtp-Source: ALg8bN5+VqLI/ZrBeyVLO96YSvCgkTfRv92CZOOWnLCrz/teO44xclhfEsz14Fmegc9tX514/yBrQiTZU1Ym2Hhc4EM= X-Received: by 2002:a7b:c853:: with SMTP id c19mr3997030wml.61.1548278268252; Wed, 23 Jan 2019 13:17:48 -0800 (PST) MIME-Version: 1.0 References: <20190123193730.GA9768@redhat.com> <1903559.vGX8tUDGlp@omega> <20190123204506.GB12500@redhat.com> <20190123210321.GA22317@altlinux.org> In-Reply-To: <20190123210321.GA22317@altlinux.org> From: Michael Hudson-Doyle Date: Thu, 24 Jan 2019 10:17:36 +1300 Message-ID: Subject: Re: test-rwlock1 failing on latest Fedora Rawhide To: "Dmitry V. Levin" Content-Type: multipart/alternative; boundary="000000000000316c68058026a0bb" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 91.189.89.112 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bruno Haible , bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" --000000000000316c68058026a0bb Content-Type: text/plain; charset="UTF-8" On Thu, 24 Jan 2019 at 10:03, Dmitry V. Levin wrote: > Hi, > > On Wed, Jan 23, 2019 at 08:45:06PM +0000, Richard W.M. Jones wrote: > > On Wed, Jan 23, 2019 at 09:01:19PM +0100, Bruno Haible wrote: > [...] > > I checked the history of the Fedora package which adds these flags, and > > it seems like --as-needed was added for: > > > > https://fedoraproject.org/wiki/Changes/RemoveExcessiveLinking > > > > Removing -Wl,--as-needed fixes the problem. However I'm still unclear > > about this. Is Fedora wrong? Is hivex using gnulib wrongly? Is > > gnulib wrong? > > We also build everything with --as-needed by default, but > gnulib does the right thing nowadays by using > -Wl,--push-state -Wl,--no-as-needed -lpthread -Wl,--pop-state > instead of plain -lpthread. > libtool can "helpfully" reorder those flags so they don't do anything though. Cheers, mwh --000000000000316c68058026a0bb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, 24 Jan 2019 at 10:03, Dmitry = V. Levin <ldv@altlinux.org> w= rote:
Hi,

On Wed, Jan 23, 2019 at 08:45:06PM +0000, Richard W.M. Jones wrote:
> On Wed, Jan 23, 2019 at 09:01:19PM +0100, Bruno Haible wrote:
[...]
> I checked the history of the Fedora package which adds these flags, an= d
> it seems like --as-needed was added for:
>
> https://fedoraproject.org/wiki/Cha= nges/RemoveExcessiveLinking
>
> Removing -Wl,--as-needed fixes the problem.=C2=A0 However I'm stil= l unclear
> about this.=C2=A0 Is Fedora wrong?=C2=A0 Is hivex using gnulib wrongly= ?=C2=A0 Is
> gnulib wrong?

We also build everything with --as-needed by default, but
gnulib does the right thing nowadays by using
-Wl,--push-state -Wl,--no-as-needed -lpthread -Wl,--pop-state
instead of plain -lpthread.

libtool can= "helpfully" reorder those flags so they don't do anything th= ough.

Cheers,
mwh=C2=A0
--000000000000316c68058026a0bb--