bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: bug-gnulib@gnu.org
Subject: Re: test-rwlock1 failing on latest Fedora Rawhide
Date: Thu, 24 Jan 2019 04:31:08 +0100	[thread overview]
Message-ID: <1892008.H1GgYAAaXj@omega> (raw)
In-Reply-To: <2073756.dCBeYvj2K1@omega>

Let me summarize the issue.

(1) The distro sets LDFLAGS="-Wl,--as-needed". So, libraries that not are not
    required through at least 1 symbol are not linked in.
(2) threadlib.m4 defines LIBMULTITHREAD in a way that is meant to defeat
    -Wl,--as-needed. But it does not work, due to the reordering of
    options done by libtool.
    So, --as-needed is still in effect.
(3) threadlib.m4 enables weak symbols, and thread.h and lock.h define
    specific symbols as weak. Weak symbols are ignored in (1).

So, the fix is to define fewer symbols as weak.

pthread_create was defined as weak, so that users of gnulib could use
glthread_create without linking with -lpthread; it would then return
ENOSYS. Now, the use of glthread_create will require linking with -lpthread,
on platforms like glibc. It may be argued that this is actually a good thing.

Bruno



  reply	other threads:[~2019-01-24  3:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23 19:37 test-rwlock1 failing on latest Fedora Rawhide Richard W.M. Jones
2019-01-23 20:01 ` Bruno Haible
2019-01-23 20:45   ` Richard W.M. Jones
2019-01-23 21:03     ` Dmitry V. Levin
2019-01-23 21:14       ` Richard W.M. Jones
2019-01-23 22:09         ` Dmitry V. Levin
2019-01-23 22:24           ` Richard W.M. Jones
2019-01-23 22:38             ` Dmitry V. Levin
2019-01-24  3:18               ` Bruno Haible
2019-01-24  3:31                 ` Bruno Haible [this message]
2019-01-24  3:49                   ` Bruno Haible
2019-01-24  8:57                     ` Richard W.M. Jones
2019-01-24  8:50               ` Richard W.M. Jones
2019-01-23 21:17       ` Michael Hudson-Doyle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1892008.H1GgYAAaXj@omega \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=ldv@altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).