From: Bernhard Voelker <mail@bernhard-voelker.de>
To: Florian Weimer <fweimer@redhat.com>, Eric Blake <eblake@redhat.com>
Cc: bug-gnulib@gnu.org, NeilBrown <neilb@suse.com>,
Jeff Layton <jlayton@redhat.com>
Subject: Re: Why does close_stdout close stdout and stderr?
Date: Mon, 6 May 2019 16:56:41 +0200 [thread overview]
Message-ID: <92136843-2556-40ad-dc5c-052f22649f0e@bernhard-voelker.de> (raw)
In-Reply-To: <87v9yneqk9.fsf@oldenburg2.str.redhat.com>
On 5/6/19 2:05 PM, Florian Weimer wrote:
>>> On 4/29/19 2:45 PM, Florian Weimer wrote:
>>>> I get that error checking is important. But why not just use ferror and
>>>> fflush? Closing the streams is excessive and tends to introduce
>>>> use-after-free issues, as evidenced by the sanitizer workarounds.
> This means that for Linux at least, close_stdout should just call
> fflush, not fclose.
What is the problem? I mean if it is use-after-free as mentioned in
the first mail, then write() after fflush() without error checking via
another fflush() is in the same category, isn't it?
Have a nice day,
Berny
next prev parent reply other threads:[~2019-05-06 14:57 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 19:45 Why does close_stdout close stdout and stderr? Florian Weimer
2019-04-29 19:49 ` Eric Blake
2019-04-29 20:26 ` Florian Weimer
2019-05-06 12:05 ` Florian Weimer
2019-05-06 14:56 ` Bernhard Voelker [this message]
2019-05-06 15:47 ` Florian Weimer
2019-05-06 19:14 ` Bernhard Voelker
2019-05-06 19:19 ` Florian Weimer
2019-05-09 6:20 ` Bernhard Voelker
2019-05-09 6:39 ` Florian Weimer
2019-05-09 9:49 ` Bernhard Voelker
2019-05-09 22:17 ` Paul Eggert
2019-05-10 7:28 ` Kamil Dudka
2019-05-10 7:31 ` Florian Weimer
2019-05-13 1:09 ` Paul Eggert
2019-05-13 7:00 ` Florian Weimer
2019-05-25 1:41 ` Paul Eggert
2019-05-25 10:58 ` Bruno Haible
2019-05-27 11:56 ` Florian Weimer
2019-05-25 11:24 ` Bruno Haible
2019-05-25 19:23 ` Paul Eggert
2019-05-27 12:00 ` Florian Weimer
2019-05-27 21:13 ` Bruno Haible
2019-05-06 18:53 ` Paul Eggert
2019-05-06 19:02 ` Jeff Layton
2019-05-06 22:32 ` Bruno Haible
2019-05-07 9:44 ` Assaf Gordon
2019-05-07 9:49 ` Assaf Gordon
2019-05-07 11:28 ` Bruno Haible
2019-05-08 0:43 ` NeilBrown
2019-05-08 11:00 ` Florian Weimer
2019-05-09 4:42 ` Paul Eggert
2019-05-09 5:01 ` Florian Weimer
2019-05-09 6:27 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92136843-2556-40ad-dc5c-052f22649f0e@bernhard-voelker.de \
--to=mail@bernhard-voelker.de \
--cc=bug-gnulib@gnu.org \
--cc=eblake@redhat.com \
--cc=fweimer@redhat.com \
--cc=jlayton@redhat.com \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).