bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Cc: Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: [PATCH 04/27] dirname: improve -fanalyzer malloc checking
Date: Sat, 07 Aug 2021 15:13:24 +0200	[thread overview]
Message-ID: <232629785.2LZladfINj@omega> (raw)
In-Reply-To: <20210802011821.1057057-4-eggert@cs.ucla.edu>

Paul Eggert wrote:
> diff --git a/lib/dirname.h b/lib/dirname.h
> index 492a4381f..04f823eca 100644
> --- a/lib/dirname.h
> +++ b/lib/dirname.h
> @@ -21,6 +21,7 @@
>  
>  # include <stdbool.h>
>  # include <stddef.h>
> +# include <stdlib.h>
>  # include "filename.h"
>  # include "basename-lgpl.h"
>  

Now that <stdlib.h> is included, the <stddef.h> include is no longer necessary
(since this module does not use 'offsetof' nor 'ptrdiff_t'). Similarly in a
couple of other files.


2021-08-07  Bruno Haible  <bruno@clisp.org>

	dirname-lgpl, sh-quote, system-quote, xstriconv: Clean up includes.
	* lib/dirname.h: Don't include <stddef.h>.
	* lib/sh-quote.h: Likewise.
	* lib/system-quote.h: Likewise.
	* lib/xstriconv.h: Likewise.

diff --git a/lib/dirname.h b/lib/dirname.h
index 04f823e..25abc7b 100644
--- a/lib/dirname.h
+++ b/lib/dirname.h
@@ -20,7 +20,6 @@
 # define DIRNAME_H_ 1
 
 # include <stdbool.h>
-# include <stddef.h>
 # include <stdlib.h>
 # include "filename.h"
 # include "basename-lgpl.h"
diff --git a/lib/sh-quote.h b/lib/sh-quote.h
index 0101036..ab440c6 100644
--- a/lib/sh-quote.h
+++ b/lib/sh-quote.h
@@ -22,7 +22,6 @@
    arguments, since Unix shells interpret characters like " ", "'", "<", ">",
    "$", '*', '?' etc. in a special way.  */
 
-#include <stddef.h>
 #include <stdlib.h>
 
 #ifdef __cplusplus
diff --git a/lib/system-quote.h b/lib/system-quote.h
index b1bbf65..6cfddd0 100644
--- a/lib/system-quote.h
+++ b/lib/system-quote.h
@@ -46,7 +46,6 @@
       is to truncate the entire command line.
  */
 
-#include <stddef.h>
 #include <stdlib.h>
 
 #ifdef __cplusplus
diff --git a/lib/xstriconv.h b/lib/xstriconv.h
index d90aa4c..879a772 100644
--- a/lib/xstriconv.h
+++ b/lib/xstriconv.h
@@ -18,7 +18,6 @@
 #ifndef _XSTRICONV_H
 #define _XSTRICONV_H
 
-#include <stddef.h>
 #include <stdlib.h>
 #if HAVE_ICONV
 #include <iconv.h>
@@ -72,6 +71,7 @@ extern char * xstr_iconv (const char *src,
                           const char *from_codeset, const char *to_codeset)
   _GL_ATTRIBUTE_MALLOC _GL_ATTRIBUTE_DEALLOC_FREE;
 
+
 #ifdef __cplusplus
 }
 #endif



  reply	other threads:[~2021-08-07 13:13 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02  1:17 [PATCH 01/27] backupfile: improve -fanalyzer malloc checking Paul Eggert
2021-08-02  1:17 ` [PATCH 02/27] maint: " Paul Eggert
2021-08-02  1:17 ` [PATCH 03/27] dfa: " Paul Eggert
2021-08-07 13:03   ` Bruno Haible
2021-08-02  1:17 ` [PATCH 04/27] dirname: " Paul Eggert
2021-08-07 13:13   ` Bruno Haible [this message]
2021-08-02  1:17 ` [PATCH 05/27] exclude: " Paul Eggert
2021-08-02  1:18 ` [PATCH 06/27] filenamecat-lgpl: " Paul Eggert
2021-08-02  1:18 ` [PATCH 07/27] malloca: " Paul Eggert
2021-08-07 13:20   ` Bruno Haible
2021-08-02  1:18 ` [PATCH 08/27] modechange: " Paul Eggert
2021-08-02  1:18 ` [PATCH 09/27] mountlist: " Paul Eggert
2021-08-02  1:18 ` [PATCH 10/27] pagalign_alloc: " Paul Eggert
2021-08-02  1:18 ` [PATCH 11/27] quotearg: " Paul Eggert
2021-08-07 13:25   ` Bruno Haible
2021-08-02  1:18 ` [PATCH 12/27] readutmp: " Paul Eggert
2021-08-02  1:18 ` [PATCH 13/27] savedir: " Paul Eggert
2021-08-02  1:18 ` [PATCH 14/27] sh-quote: " Paul Eggert
2021-08-02  1:18 ` [PATCH 15/27] system-quote: " Paul Eggert
2021-08-02  1:18 ` [PATCH 16/27] trim: " Paul Eggert
2021-08-02  1:18 ` [PATCH 17/27] xgetcwd: " Paul Eggert
2021-08-02  1:18 ` [PATCH 18/27] xgethostname: " Paul Eggert
2021-08-02  1:18 ` [PATCH 19/27] xmalloca: " Paul Eggert
2021-08-02  1:18 ` [PATCH 20/27] xreadlink: " Paul Eggert
2021-08-02  1:18 ` [PATCH 21/27] xstriconv: " Paul Eggert
2021-08-02  1:18 ` [PATCH 22/27] xvasprintf: " Paul Eggert
2021-08-02  1:18 ` [PATCH 23/27] vasnprintf: " Paul Eggert
2021-08-02  1:18 ` [PATCH 24/27] argmatch-tests: " Paul Eggert
2021-08-02  1:18 ` [PATCH 25/27] manywarnings: " Paul Eggert
2021-08-02  1:18 ` [PATCH 26/27] sigsegv-tests: make more things static Paul Eggert
2021-08-07 13:47   ` Bruno Haible
2021-08-02  1:18 ` [PATCH 27/27] * lib/quotarg.c: remove wrong, unneeded comment Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=232629785.2LZladfINj@omega \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).