From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 64BB71F8C6 for ; Sat, 7 Aug 2021 13:13:41 +0000 (UTC) Received: from localhost ([::1]:49678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mCM8y-0006dD-2Q for normalperson@yhbt.net; Sat, 07 Aug 2021 09:13:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCM8u-0006cf-HP for bug-gnulib@gnu.org; Sat, 07 Aug 2021 09:13:36 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.20]:12598) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCM8s-0003k7-Sh for bug-gnulib@gnu.org; Sat, 07 Aug 2021 09:13:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1628342005; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=i8YhA5K1XzPccCdVAk2PdwHw4teQ/2FaEV9lE9arF1E=; b=b/PD7Nr5T/pDLT3biYwFqemSZpyloyp7ifeAsPfVCddLrYF50y+hGZPmikcNjHNKwZ P99Z1MUtBSVAAUfBsv1mp/kJ1gvaqDJs2i4Duga30kQasfUV1ycQcW7rKbvTKF5a6HYn ZCSc5g3XazHxn9E24yyaRcpXlzZGXhvLxTICYa3v4KfaM6YmGQwAWJeLdjDzQgQO2sxo udGsjnF4cqql3Sh9RHIz/1ehvDw/nNGKoI0/D9f/MgPYtJv52Q9E3Cq+shriWXDJmVtT j1N0cXlZz/G6Dp8ETW7p/FSrbDw0lway1MRGxQc4d0vGKQxXsp8dQcxY4nGvogr8iwb2 y+Wg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH/DXj0JGsbh0vbrMZq" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 47.31.0 DYNA|AUTH) with ESMTPSA id I0a189x77DDPFMd (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Sat, 7 Aug 2021 15:13:25 +0200 (CEST) From: Bruno Haible To: bug-gnulib@gnu.org Subject: Re: [PATCH 04/27] dirname: improve -fanalyzer malloc checking Date: Sat, 07 Aug 2021 15:13:24 +0200 Message-ID: <232629785.2LZladfINj@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-210-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20210802011821.1057057-4-eggert@cs.ucla.edu> References: <20210802011821.1057057-1-eggert@cs.ucla.edu> <20210802011821.1057057-4-eggert@cs.ucla.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=85.215.255.20; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Eggert Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Paul Eggert wrote: > diff --git a/lib/dirname.h b/lib/dirname.h > index 492a4381f..04f823eca 100644 > --- a/lib/dirname.h > +++ b/lib/dirname.h > @@ -21,6 +21,7 @@ > > # include > # include > +# include > # include "filename.h" > # include "basename-lgpl.h" > Now that is included, the include is no longer necessary (since this module does not use 'offsetof' nor 'ptrdiff_t'). Similarly in a couple of other files. 2021-08-07 Bruno Haible dirname-lgpl, sh-quote, system-quote, xstriconv: Clean up includes. * lib/dirname.h: Don't include . * lib/sh-quote.h: Likewise. * lib/system-quote.h: Likewise. * lib/xstriconv.h: Likewise. diff --git a/lib/dirname.h b/lib/dirname.h index 04f823e..25abc7b 100644 --- a/lib/dirname.h +++ b/lib/dirname.h @@ -20,7 +20,6 @@ # define DIRNAME_H_ 1 # include -# include # include # include "filename.h" # include "basename-lgpl.h" diff --git a/lib/sh-quote.h b/lib/sh-quote.h index 0101036..ab440c6 100644 --- a/lib/sh-quote.h +++ b/lib/sh-quote.h @@ -22,7 +22,6 @@ arguments, since Unix shells interpret characters like " ", "'", "<", ">", "$", '*', '?' etc. in a special way. */ -#include #include #ifdef __cplusplus diff --git a/lib/system-quote.h b/lib/system-quote.h index b1bbf65..6cfddd0 100644 --- a/lib/system-quote.h +++ b/lib/system-quote.h @@ -46,7 +46,6 @@ is to truncate the entire command line. */ -#include #include #ifdef __cplusplus diff --git a/lib/xstriconv.h b/lib/xstriconv.h index d90aa4c..879a772 100644 --- a/lib/xstriconv.h +++ b/lib/xstriconv.h @@ -18,7 +18,6 @@ #ifndef _XSTRICONV_H #define _XSTRICONV_H -#include #include #if HAVE_ICONV #include @@ -72,6 +71,7 @@ extern char * xstr_iconv (const char *src, const char *from_codeset, const char *to_codeset) _GL_ATTRIBUTE_MALLOC _GL_ATTRIBUTE_DEALLOC_FREE; + #ifdef __cplusplus } #endif