From: Paul Eggert <eggert@cs.ucla.edu>
To: bug-gnulib@gnu.org
Cc: Paul Eggert <eggert@cs.ucla.edu>
Subject: [PATCH 14/27] sh-quote: improve -fanalyzer malloc checking
Date: Sun, 1 Aug 2021 18:18:08 -0700 [thread overview]
Message-ID: <20210802011821.1057057-14-eggert@cs.ucla.edu> (raw)
In-Reply-To: <20210802011821.1057057-1-eggert@cs.ucla.edu>
---
ChangeLog | 2 +-
lib/sh-quote.h | 9 +++++++--
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 45fd8cad5..6c81691fb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -5,7 +5,7 @@
* lib/canonicalize.h, lib/dfa.h, lib/dirname.h, lib/exclude.h:
* lib/filenamecat.h, lib/malloca.h, lib/modechange.h:
* lib/mountlist.h, lib/pagealign_alloc.h, lib/quotearg.h:
- * lib/readutmp.h, lib/savedir.h:
+ * lib/readutmp.h, lib/savedir.h, lib/sh-quote.h:
Add malloc-related attributes and include stdlib.h as needed.
* lib/dfa.c: Include verify.h.
(assume_nonnull): New macro.
diff --git a/lib/sh-quote.h b/lib/sh-quote.h
index e543e4063..0101036e5 100644
--- a/lib/sh-quote.h
+++ b/lib/sh-quote.h
@@ -23,6 +23,7 @@
"$", '*', '?' etc. in a special way. */
#include <stddef.h>
+#include <stdlib.h>
#ifdef __cplusplus
extern "C" {
@@ -36,11 +37,15 @@ extern size_t shell_quote_length (const char *string);
extern char * shell_quote_copy (char *restrict p, const char *string);
/* Returns the freshly allocated quoted string. */
-extern char * shell_quote (const char *string);
+extern char * shell_quote (const char *string)
+ _GL_ATTRIBUTE_MALLOC _GL_ATTRIBUTE_DEALLOC_FREE
+ _GL_ATTRIBUTE_RETURNS_NONNULL;
/* Returns a freshly allocated string containing all argument strings, quoted,
separated through spaces. */
-extern char * shell_quote_argv (const char * const *argv);
+extern char * shell_quote_argv (const char * const *argv)
+ _GL_ATTRIBUTE_MALLOC _GL_ATTRIBUTE_DEALLOC_FREE
+ _GL_ATTRIBUTE_RETURNS_NONNULL;
#ifdef __cplusplus
}
--
2.31.1
next prev parent reply other threads:[~2021-08-02 1:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 1:17 [PATCH 01/27] backupfile: improve -fanalyzer malloc checking Paul Eggert
2021-08-02 1:17 ` [PATCH 02/27] maint: " Paul Eggert
2021-08-02 1:17 ` [PATCH 03/27] dfa: " Paul Eggert
2021-08-07 13:03 ` Bruno Haible
2021-08-02 1:17 ` [PATCH 04/27] dirname: " Paul Eggert
2021-08-07 13:13 ` Bruno Haible
2021-08-02 1:17 ` [PATCH 05/27] exclude: " Paul Eggert
2021-08-02 1:18 ` [PATCH 06/27] filenamecat-lgpl: " Paul Eggert
2021-08-02 1:18 ` [PATCH 07/27] malloca: " Paul Eggert
2021-08-07 13:20 ` Bruno Haible
2021-08-02 1:18 ` [PATCH 08/27] modechange: " Paul Eggert
2021-08-02 1:18 ` [PATCH 09/27] mountlist: " Paul Eggert
2021-08-02 1:18 ` [PATCH 10/27] pagalign_alloc: " Paul Eggert
2021-08-02 1:18 ` [PATCH 11/27] quotearg: " Paul Eggert
2021-08-07 13:25 ` Bruno Haible
2021-08-02 1:18 ` [PATCH 12/27] readutmp: " Paul Eggert
2021-08-02 1:18 ` [PATCH 13/27] savedir: " Paul Eggert
2021-08-02 1:18 ` Paul Eggert [this message]
2021-08-02 1:18 ` [PATCH 15/27] system-quote: " Paul Eggert
2021-08-02 1:18 ` [PATCH 16/27] trim: " Paul Eggert
2021-08-02 1:18 ` [PATCH 17/27] xgetcwd: " Paul Eggert
2021-08-02 1:18 ` [PATCH 18/27] xgethostname: " Paul Eggert
2021-08-02 1:18 ` [PATCH 19/27] xmalloca: " Paul Eggert
2021-08-02 1:18 ` [PATCH 20/27] xreadlink: " Paul Eggert
2021-08-02 1:18 ` [PATCH 21/27] xstriconv: " Paul Eggert
2021-08-02 1:18 ` [PATCH 22/27] xvasprintf: " Paul Eggert
2021-08-02 1:18 ` [PATCH 23/27] vasnprintf: " Paul Eggert
2021-08-02 1:18 ` [PATCH 24/27] argmatch-tests: " Paul Eggert
2021-08-02 1:18 ` [PATCH 25/27] manywarnings: " Paul Eggert
2021-08-02 1:18 ` [PATCH 26/27] sigsegv-tests: make more things static Paul Eggert
2021-08-07 13:47 ` Bruno Haible
2021-08-02 1:18 ` [PATCH 27/27] * lib/quotarg.c: remove wrong, unneeded comment Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210802011821.1057057-14-eggert@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).