From: Roman Bolshakov <r.bolshakov@yadro.com>
To: <bug-gnulib@gnu.org>
Cc: Roman Bolshakov <r.bolshakov@yadro.com>
Subject: [PATCH v3 0/2] Fix syntax-check on macOS/FreeBSD
Date: Thu, 13 Dec 2018 18:34:51 +0300 [thread overview]
Message-ID: <20181213153453.38123-1-r.bolshakov@yadro.com> (raw)
Hello,
There was an issue with syntax-check on FreeBSD reported a few years
ago:
https://www.redhat.com/archives/libvir-list/2015-August/msg00758.html
http://lists.gnu.org/archive/html/bug-gnulib/2015-08/msg00019.html
The patch series attempts to resolve the issue on gnulib side. With
related changes on libvirt side I can run make syntax-check on macOS.
* modules/maintainer-makefile (configure.ac): Look for the best
available ggrep or grep with AC_PROG_GREP.
* top/maint.mk: Split long argument lists with xargs. Replace grep
invocations with $(GREP).
v2: http://lists.gnu.org/archive/html/bug-gnulib/2018-12/msg00026.html
Changes since v2:
- removed /dev/null argument for grep invocations with "-l" flag
- reformatted all affected multi-line commands to be more consistent
with the style of the code around with regards to &&, || and |
- removed dependency on mkdir in sc_prohibit_always-defined_macros
- rewrote sc_po_check to avoid running perl with $(generated_files)
multiple times
- rewrote sc_cross_check_PATH_usage_in_tests to simplify indentation
v1: http://lists.gnu.org/archive/html/bug-gnulib/2018-11/msg00069.html
Changes since v1:
- removed VC_ARG_MAX
- removed "-n" flag in xargs invocations
- added /dev/null as an extra file for uniform grep output regardless of
number of files. The file isn't added if grep invocation has "-L" flag
- added dependency on AC_PROG_GREP to modules/maintainer-makefile
--
Best regards,
Roman
Roman Bolshakov (2):
maint.mk: Split long argument lists
maint.mk: Replace grep with $(GREP)
modules/maintainer-makefile | 1 +
top/maint.mk | 207 +++++++++++++++++++++---------------
2 files changed, 123 insertions(+), 85 deletions(-)
--
2.17.2 (Apple Git-113)
next reply other threads:[~2018-12-13 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 15:34 Roman Bolshakov [this message]
2018-12-13 15:34 ` [PATCH v3 1/2] maint.mk: Split long argument lists Roman Bolshakov
2019-01-02 19:31 ` Eric Blake
2018-12-13 15:34 ` [PATCH v3 2/2] maint.mk: Replace grep with $(GREP) Roman Bolshakov
2018-12-20 13:06 ` [PATCH v3 0/2] Fix syntax-check on macOS/FreeBSD Roman Bolshakov
2019-01-02 20:14 ` Eric Blake
2019-01-03 14:44 ` Eric Blake
2019-01-03 15:28 ` Eric Blake
2019-01-06 21:36 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213153453.38123-1-r.bolshakov@yadro.com \
--to=r.bolshakov@yadro.com \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).